Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2378)

Unified Diff: presubmit_canned_checks.py

Issue 1090943003: Skip OWNERS checks for CQ dry runs (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Cleanup Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index bba7737284127cceb244d60255f6bee10c4244c6..a35cf59f2c8ca73b613a9386575fc43ea05546c5 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -854,7 +854,11 @@ def CheckOwners(input_api, output_api, source_file_filter=None):
if input_api.tbr:
return [output_api.PresubmitNotifyResult(
'--tbr was specified, skipping OWNERS check')]
- if not input_api.change.issue:
+ if input_api.change.issue:
+ if _GetRietveldIssueProps(input_api, None).get('cq_dry_run', False):
+ return [output_api.PresubmitNotifyResult(
+ 'This is a CQ dry run, skipping OWNERS check')]
+ else:
return [output_api.PresubmitError("OWNERS check failed: this change has "
"no Rietveld issue number, so we can't check it for approvals.")]
needed = 'LGTM from an OWNER'
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698