Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10909216: NaCl: Fix ARM Gyp build of IRT to include IRT-private __aeabi_read_tp (Closed)

Created:
8 years, 3 months ago by Roland McGrath
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Nikolay
Visibility:
Public.

Description

NaCl: Fix ARM Gyp build of IRT to include IRT-private __aeabi_read_tp The Gyp build rules for the IRT omitted the aeabi_read_tp.S file for ARM. This is essential to the IRT working correctly. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3028 TEST= new gyp target nacl_irt_tls_check R=mseaborn@chromium.org,sehr@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M ppapi/native_client/native_client.gyp View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Roland McGrath
8 years, 3 months ago (2012-09-13 22:27:28 UTC) #1
Mark Seaborn
8 years, 3 months ago (2012-09-13 23:06:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698