Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: ppapi/native_client/native_client.gyp

Issue 10909216: NaCl: Fix ARM Gyp build of IRT to include IRT-private __aeabi_read_tp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/native_client.gyp
diff --git a/ppapi/native_client/native_client.gyp b/ppapi/native_client/native_client.gyp
index 8a94c3abcbf8df6c8860e10c195d3362094277a0..be2e727fccfa3e8908ffc2e57b4c85aa44de8e23 100644
--- a/ppapi/native_client/native_client.gyp
+++ b/ppapi/native_client/native_client.gyp
@@ -108,11 +108,20 @@
'conditions': [
['target_arch!="arm"',
{
+ 'sources': [
+ ],
'link_flags': [
'-Wl,--section-start,.rodata=<(NACL_IRT_DATA_START)',
'-Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)',
]
}, { # target_arch == "arm"
+ # TODO(mcgrathr): This knowledge really belongs in
+ # native_client/src/untrusted/irt/irt.gyp instead of here.
+ # But that builds libirt_browser.a as bitcode, so a native
+ # object does not fit happily there.
+ 'sources': [
+ '../../native_client/src/untrusted/irt/aeabi_read_tp.S',
+ ],
'link_flags': [
'-Wl,--section-start,.rodata=<(NACL_IRT_DATA_START)',
'-Wl,-Ttext=<(NACL_IRT_TEXT_START)',
@@ -123,8 +132,6 @@
},
],
],
- 'sources': [
- ],
'extra_args': [
'--strip-debug',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698