Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10908184: Enforce the 'requirements' field in manifests. (Closed)

Created:
8 years, 3 months ago by eaugusti
Modified:
8 years, 3 months ago
Reviewers:
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, ncarter (slow), mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Raghu Simha, jianli, rdsmith+dwatch_chromium.org, dcheng, Dmitry Titov, Aaron Boodman, rginda+watch_chromium.org, jennb, tim (not reviewing), oshima+watch_chromium.org, estade+watch_chromium.org, haitaol1, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, akalin
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1052 lines, -84 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.h View 4 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 5 chunks +36 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 5 chunks +113 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A chrome/browser/extensions/requirements_checker.h View 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/browser/extensions/requirements_checker.cc View 1 chunk +98 lines, -0 lines 0 comments Download
A chrome/browser/extensions/requirements_checker_browsertest.cc View 1 chunk +190 lines, -0 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.h View 5 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 9 chunks +46 lines, -19 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 4 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 4 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/install_extension_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 6 chunks +17 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 4 chunks +85 lines, -25 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc View 1 chunk +80 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/init_invalid_requirements_1.json View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/init_invalid_requirements_2.json View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/init_valid_app_requirements.json View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_invalid_3d.json View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_invalid_3d_features.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_invalid_3d_features_value.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_invalid_3d_no_features.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_invalid_keys.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_invalid_plugins.json View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_invalid_plugins_key.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_invalid_plugins_value.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_invalid_requirements.json View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_npapi.json View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_npapi_empty.json View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_valid_empty.json View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/requirements_valid_full.json View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/requirements/v1_good.pem View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/requirements/v1_good/manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/requirements/v2_bad_requirements/manifest.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/requirements/v2_bad_requirements_and_permissions/manifest.json View 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/requirements/v3_bad_permissions/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/requirements/v3_good/manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/requirements_checker/no_requirements/manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/requirements_checker/require_3d/manifest.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/requirements_checker/require_npapi/manifest.json View 1 chunk +10 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698