Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 10908184: Enforce the 'requirements' field in manifests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/base64.h" 8 #include "base/base64.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/file_util.h" 12 #include "base/file_util.h"
13 #include "base/string_util.h"
13 #include "base/string_number_conversions.h" 14 #include "base/string_number_conversions.h"
14 #include "base/utf_string_conversions.h" 15 #include "base/utf_string_conversions.h"
15 #include "base/values.h" 16 #include "base/values.h"
16 #include "base/version.h" 17 #include "base/version.h"
17 #include "chrome/browser/browser_process.h" 18 #include "chrome/browser/browser_process.h"
18 #include "chrome/browser/debugger/devtools_window.h" 19 #include "chrome/browser/debugger/devtools_window.h"
19 #include "chrome/browser/extensions/crx_installer.h" 20 #include "chrome/browser/extensions/crx_installer.h"
20 #include "chrome/browser/extensions/extension_disabled_ui.h" 21 #include "chrome/browser/extensions/extension_disabled_ui.h"
22 #include "chrome/browser/extensions/extension_error_reporter.h"
21 #include "chrome/browser/extensions/extension_host.h" 23 #include "chrome/browser/extensions/extension_host.h"
22 #include "chrome/browser/extensions/extension_service.h" 24 #include "chrome/browser/extensions/extension_service.h"
23 #include "chrome/browser/extensions/extension_system.h" 25 #include "chrome/browser/extensions/extension_system.h"
24 #include "chrome/browser/extensions/extension_warning_set.h" 26 #include "chrome/browser/extensions/extension_warning_set.h"
25 #include "chrome/browser/extensions/lazy_background_task_queue.h" 27 #include "chrome/browser/extensions/lazy_background_task_queue.h"
26 #include "chrome/browser/extensions/unpacked_installer.h" 28 #include "chrome/browser/extensions/unpacked_installer.h"
27 #include "chrome/browser/extensions/updater/extension_updater.h" 29 #include "chrome/browser/extensions/updater/extension_updater.h"
28 #include "chrome/browser/google/google_util.h" 30 #include "chrome/browser/google/google_util.h"
29 #include "chrome/browser/managed_mode.h" 31 #include "chrome/browser/managed_mode.h"
30 #include "chrome/browser/prefs/pref_service.h" 32 #include "chrome/browser/prefs/pref_service.h"
(...skipping 586 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 return; 619 return;
618 } 620 }
619 621
620 if (enable_str == "true") { 622 if (enable_str == "true") {
621 extensions::ExtensionPrefs* prefs = extension_service_->extension_prefs(); 623 extensions::ExtensionPrefs* prefs = extension_service_->extension_prefs();
622 if (prefs->DidExtensionEscalatePermissions(extension_id)) { 624 if (prefs->DidExtensionEscalatePermissions(extension_id)) {
623 Browser* browser = browser::FindBrowserWithWebContents( 625 Browser* browser = browser::FindBrowserWithWebContents(
624 web_ui()->GetWebContents()); 626 web_ui()->GetWebContents());
625 extensions::ShowExtensionDisabledDialog( 627 extensions::ShowExtensionDisabledDialog(
626 extension_service_, browser, extension); 628 extension_service_, browser, extension);
629 } else if ((prefs->GetDisableReasons(extension_id) &
630 Extension::DISABLE_UNSUPPORTED_REQUIREMENT) &&
631 !requirements_checker_.get()) {
632 // Recheck the requirements.
633 scoped_refptr<const Extension> extension =
634 extension_service_->GetExtensionById(extension_id,
635 true /* include disabled */);
636 requirements_checker_.reset(new extensions::RequirementsChecker());
637 requirements_checker_->Check(
638 extension,
639 base::Bind(&ExtensionSettingsHandler::OnRequirementsChecked,
640 AsWeakPtr(), extension_id));
627 } else { 641 } else {
628 extension_service_->EnableExtension(extension_id); 642 extension_service_->EnableExtension(extension_id);
629 } 643 }
630 } else { 644 } else {
631 extension_service_->DisableExtension( 645 extension_service_->DisableExtension(
632 extension_id, Extension::DISABLE_USER_ACTION); 646 extension_id, Extension::DISABLE_USER_ACTION);
633 } 647 }
634 } 648 }
635 649
636 void ExtensionSettingsHandler::HandleEnableIncognitoMessage( 650 void ExtensionSettingsHandler::HandleEnableIncognitoMessage(
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
880 #else 894 #else
881 return NULL; 895 return NULL;
882 #endif // !defined(OS_ANDROID) 896 #endif // !defined(OS_ANDROID)
883 } 897 }
884 898
885 void ExtensionSettingsHandler::InspectExtensionHost( 899 void ExtensionSettingsHandler::InspectExtensionHost(
886 extensions::ExtensionHost* host) { 900 extensions::ExtensionHost* host) {
887 if (host) 901 if (host)
888 DevToolsWindow::OpenDevToolsWindow(host->render_view_host()); 902 DevToolsWindow::OpenDevToolsWindow(host->render_view_host());
889 } 903 }
904
905 void ExtensionSettingsHandler::OnRequirementsChecked(
906 std::string extension_id,
907 std::vector<std::string> requirement_errors) {
908 if (requirement_errors.empty()) {
909 extension_service_->EnableExtension(extension_id);
910 } else {
911 ExtensionErrorReporter::GetInstance()->ReportError(
912 UTF8ToUTF16(JoinString(requirement_errors, ' ')),
913 true /* be noisy */);
914 }
915 requirements_checker_.reset();
916 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698