[crankshaft] Fix property access with proxies in prototype chain

[crankshaft] Fix property access with proxies in prototype chain

BUG=

Committed: https://crrev.com/c153a8437e2d4f579f65485d7fc9f2f751010624
Cr-Commit-Position: refs/heads/master@{#27911}

[Toon Verwaest, 2015-04-16 10:46:47]

verwaest@chromium.org changed reviewers:
+ rossberg@chromium.org

[Toon Verwaest, 2015-04-16 10:46:47]

PTAL

[rossberg, 2015-04-16 10:54:13]

LGTM, almost

https://codereview.chromium.org/1090813003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/1090813003/diff/1/src/hydrogen.cc#newcode5450
src/hydrogen.cc:5450: if (map->instance_type() == JS_PROXY_TYPE) return false;
This isn't actually needed, I assume.

https://codereview.chromium.org/1090813003/diff/1/src/hydrogen.cc#newcode6074
src/hydrogen.cc:6074: if (map->IsJSReceiverMap()) {
You may want to set NotFound in this case as well (you can just return
!map->IsJSReceiverMap() below).

[Toon Verwaest, 2015-04-16 10:58:44]

Addressed comments

[Toon Verwaest, 2015-04-16 10:58:47]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-04-16 10:58:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1090813003/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2015-04-16 10:58:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090813003/20001

[commit-bot: I haz the power, 2015-04-16 11:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 11:08:58]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Toon Verwaest, 2015-04-16 13:59:40]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-04-16 13:59:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090813003/20001

[commit-bot: I haz the power, 2015-04-16 14:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 14:14:53]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Toon Verwaest, 2015-04-16 16:55:00]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-04-16 16:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1090813003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-04-16 16:55:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090813003/40001

[commit-bot: I haz the power, 2015-04-16 17:16:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 17:16:46]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Toon Verwaest, 2015-04-17 08:59:44]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-04-17 08:59:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1090813003/#ps80001
(title: "Have to check the prototype instead")

[commit-bot: I haz the power, 2015-04-17 08:59:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1090813003/80001

[commit-bot: I haz the power, 2015-04-17 09:25:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-17 09:25:40]

Patchset 5 (id:??) landed as
https://crrev.com/c153a8437e2d4f579f65485d7fc9f2f751010624
Cr-Commit-Position: refs/heads/master@{#27911}