Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: src/hydrogen.cc

Issue 1090813003: [crankshaft] Fix property access with proxies in prototype chain (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Have to check the prototype instead Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/harmony/proxies.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/hydrogen.h" 5 #include "src/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 6096 matching lines...) Expand 10 before | Expand all | Expand 10 after
6107 JSObject::TryMigrateInstance(holder_); 6107 JSObject::TryMigrateInstance(holder_);
6108 } 6108 }
6109 map = Handle<Map>(holder_->map()); 6109 map = Handle<Map>(holder_->map());
6110 if (!CanInlinePropertyAccess(map)) { 6110 if (!CanInlinePropertyAccess(map)) {
6111 NotFound(); 6111 NotFound();
6112 return false; 6112 return false;
6113 } 6113 }
6114 LookupDescriptor(*map, *name_); 6114 LookupDescriptor(*map, *name_);
6115 if (IsFound()) return LoadResult(map); 6115 if (IsFound()) return LoadResult(map);
6116 } 6116 }
6117
6117 NotFound(); 6118 NotFound();
6118 return true; 6119 return !map->prototype()->IsJSReceiver();
6119 } 6120 }
6120 6121
6121 6122
6122 bool HOptimizedGraphBuilder::PropertyAccessInfo::IsIntegerIndexedExotic() { 6123 bool HOptimizedGraphBuilder::PropertyAccessInfo::IsIntegerIndexedExotic() {
6123 InstanceType instance_type = map_->instance_type(); 6124 InstanceType instance_type = map_->instance_type();
6124 return instance_type == JS_TYPED_ARRAY_TYPE && 6125 return instance_type == JS_TYPED_ARRAY_TYPE &&
6125 IsSpecialIndex(isolate()->unicode_cache(), *name_); 6126 IsSpecialIndex(isolate()->unicode_cache(), *name_);
6126 } 6127 }
6127 6128
6128 6129
(...skipping 6835 matching lines...) Expand 10 before | Expand all | Expand 10 after
12964 if (ShouldProduceTraceOutput()) { 12965 if (ShouldProduceTraceOutput()) {
12965 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 12966 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
12966 } 12967 }
12967 12968
12968 #ifdef DEBUG 12969 #ifdef DEBUG
12969 graph_->Verify(false); // No full verify. 12970 graph_->Verify(false); // No full verify.
12970 #endif 12971 #endif
12971 } 12972 }
12972 12973
12973 } } // namespace v8::internal 12974 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/harmony/proxies.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698