runtime/bin/socket_linux.cc - Issue 10907248: Don't use TEMP_FAILURE_RETRY macro with inet_addr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_linux.cc

Issue 10907248: Don't use TEMP_FAILURE_RETRY macro with inet_addr (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Modify change list to remove description of potential infinite loop. Not sure it is really possible. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/socket_linux.cc

diff --git a/runtime/bin/socket_linux.cc b/runtime/bin/socket_linux.cc

index 37ceda5726bb06433321375472ef1d5a22d3d970..05f225bd45728cb8fa16c40c16cd270c40a31be2 100644

--- a/runtime/bin/socket_linux.cc

+++ b/runtime/bin/socket_linux.cc

@@ -176,7 +176,7 @@ intptr_t ServerSocket::CreateBindListen(const char* host,

intptr_t fd;

struct sockaddr_in server_address;

- in_addr_t s_addr = TEMP_FAILURE_RETRY(inet_addr(host));

+ in_addr_t s_addr = inet_addr(host);

if (s_addr == INADDR_NONE) {

return -5;

}

« no previous file with comments | « runtime/bin/socket_android.cc ('k') | runtime/bin/socket_macos.cc » ('j') | no next file with comments »