Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: runtime/bin/socket_android.cc

Issue 10907248: Don't use TEMP_FAILURE_RETRY macro with inet_addr (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Modify change list to remove description of potential infinite loop. Not sure it is really possible. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/socket_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_android.cc
diff --git a/runtime/bin/socket_android.cc b/runtime/bin/socket_android.cc
index bac73c1e3dec23a425b4d7732d7adc8ec4880027..d4960f6e23964566bcab6e17157c1502914e9d6e 100644
--- a/runtime/bin/socket_android.cc
+++ b/runtime/bin/socket_android.cc
@@ -177,12 +177,7 @@ intptr_t ServerSocket::CreateBindListen(const char* host,
intptr_t fd;
struct sockaddr_in server_address;
- // Cast to/from int to work-around Android bug:
- // http://code.google.com/p/android/issues/detail?id=37426
- // unistd.h TEMP_FAILURE_RETRY generates warning when used with syscall that
- // returns unsigned int.
- in_addr_t s_addr = static_cast<in_addr_t>(
- TEMP_FAILURE_RETRY(static_cast<int>(inet_addr(host))));
+ in_addr_t s_addr = inet_addr(host);
if (s_addr == INADDR_NONE) {
return -5;
}
« no previous file with comments | « no previous file | runtime/bin/socket_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698