compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java - Issue 10907215: Issue 3553. Stop treating static final variables as constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

Issue 10907215: Issue 3553. Stop treating static final variables as constants (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweaks for tests Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Resolver.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

index f728ad6d6a5f1ea043df96f8873dd76caad41c00..7eb66ee3133b5dac55ddedadb415cec9a931e19f 100644

--- a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

+++ b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

@@ -281,10 +281,6 @@ public class TopLevelElementBuilder {

@Override

public Void visitField(DartField node) {

Modifiers modifiers = node.getModifiers();

- if (modifiers.isFinal()) {

- // final top-level fields are implicitly compile-time constants.

- modifiers = modifiers.makeConstant();

- }

node.setElement(Elements.fieldFromNode(node, library, node.getObsoleteMetadata(), modifiers));

return null;

}