Issue 1090713002: Fix typo in sky_tool causing crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1090713002: Fix typo in sky_tool causing crash (Closed)

Created:
5 years, 8 months ago by eseidel

Modified:
5 years, 8 months ago

Reviewers:
Hixie

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix typo in sky_tool causing crash This will require me to roll the sky pub package, sigh. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a99c6ae610117a385fed8db650ddf0cb4acb0054

Patch Set 1 #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sky/sdk/packages/sky/lib/sky_tool	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

https://codereview.chromium.org/1090713002/diff/1/sky/sdk/packages/sky/lib/sky_tool File sky/sdk/packages/sky/lib/sky_tool (right): https://codereview.chromium.org/1090713002/diff/1/sky/sdk/packages/sky/lib/sky_tool#newcode214 sky/sdk/packages/sky/lib/sky_tool:214: subprocess.check_output([ADB_PATH, 'devices']) This was to hide the output. --help ...

5 years, 8 months ago (2015-04-15 20:28:20 UTC) #1

eseidel

5 years, 8 months ago (2015-04-15 20:29:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a99c6ae610117a385fed8db650ddf0cb4acb0054 (presubmit successful).

Expand Messages | Collapse Messages