Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: sky/sdk/packages/sky/lib/sky_tool

Issue 1090713002: Fix typo in sky_tool causing crash (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/packages/sky/lib/sky_tool
diff --git a/sky/sdk/packages/sky/lib/sky_tool b/sky/sdk/packages/sky/lib/sky_tool
index f7b8b6f116411740fe3bfbafc86d241f13019619..d245deac858b110b430308ddb42cc1ae1fc888e8 100755
--- a/sky/sdk/packages/sky/lib/sky_tool
+++ b/sky/sdk/packages/sky/lib/sky_tool
@@ -211,7 +211,7 @@ class StopSky(object):
class SkyShellRunner(object):
def _check_for_adb(self):
try:
- subprocess.call([ADB_PATH, '--help'])
+ subprocess.check_output([ADB_PATH, 'devices'])
eseidel 2015/04/15 20:28:20 This was to hide the output. --help isn't a valid
except OSError:
print "'adb' (from the Android SDK) not in $PATH, can't continue."
return False
@@ -220,7 +220,7 @@ class SkyShellRunner(object):
def main(self):
logging.basicConfig(level=logging.WARNING)
- if not self._check_for_adb()
+ if not self._check_for_adb():
sys.exit(2)
parser = argparse.ArgumentParser(description='Sky Demo Runner')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698