Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090693002: Replace FX_NEW with new, remove tests in fpdfdoc. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -92 lines) Patch
M core/src/fpdfdoc/doc_annot.cpp View 3 chunks +3 lines, -12 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 4 chunks +4 lines, -10 lines 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/fpdfdoc/doc_metadata.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 6 chunks +6 lines, -21 lines 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 7 chunks +17 lines, -23 lines 0 comments Download
M core/src/fpdfdoc/doc_vtmodule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/pdf_vt.h View 3 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei.
5 years, 8 months ago (2015-04-15 22:38:07 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1090693002/diff/1/core/src/fpdfdoc/doc_form.cpp File core/src/fpdfdoc/doc_form.cpp (right): https://codereview.chromium.org/1090693002/diff/1/core/src/fpdfdoc/doc_form.cpp#newcode129 core/src/fpdfdoc/doc_form.cpp:129: Node *pNode = new _Node; nit: Node* pNode ...
5 years, 8 months ago (2015-04-16 18:35:09 UTC) #3
Tom Sepez
5 years, 8 months ago (2015-04-16 21:13:19 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
357d16f8453c2cf0c0afd00eec9e86d03d55fe69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698