Replace FX_NEW with new, remove tests in fpdfdoc.

core/src/fpdfdoc/doc_form.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 #include "../../include/fxcrt/fx_xml.h"
 CFX_WideString  GetFullName(CPDF_Dictionary* pFieldDict);
 void                    InitInterFormDict(CPDF_Dictionary*& pFormDict, CPDF_Document* pDocument);
@@ skipping 108 matching lines @@
 }
 CFieldTree::~CFieldTree()
 {
     RemoveAll();
 }
 CFieldTree::_Node *CFieldTree::AddChild(_Node *pParent, const CFX_WideString &short_name, CPDF_FormField *field_ptr)
 {
     if (pParent == NULL) {
         return NULL;
     }
-    _Node *pNode = FX_NEW _Node;
-    if (pNode == NULL) {
-        return NULL;
-    }
+    _Node* pNode = new _Node;
     pNode->parent = pParent;
     pNode->short_name = short_name;
     pNode->field_ptr = field_ptr;
     pParent->children.Add(pNode);
     return pNode;
 }
 void CFieldTree::RemoveNode(_Node *pNode, int nLevel)
 {
     if (pNode == NULL) {
         return ;
@@ skipping 120 matching lines @@
         name_extractor.GetNext(pName, nLength);
     }
     return pNode;
 }
 CPDF_InterForm::CPDF_InterForm(CPDF_Document* pDocument, FX_BOOL bGenerateAP) : CFX_PrivateData()
 {
     m_pDocument = pDocument;
     m_bGenerateAP = bGenerateAP;
     m_pFormNotify = NULL;
     m_bUpdated = FALSE;
-    m_pFieldTree = FX_NEW CFieldTree;
+    m_pFieldTree = new CFieldTree;
     CPDF_Dictionary* pRoot = m_pDocument->GetRoot();
     m_pFormDict = pRoot->GetDict("AcroForm");
     if (m_pFormDict == NULL) {
         return;
     }
     CPDF_Array* pFields = m_pFormDict->GetArray("Fields");
     if (pFields == NULL) {
         return;
     }
     int count = pFields->GetCount();
@@ skipping 1043 matching lines @@
                     pParent->SetAt(FX_BSTRC("FT"), pFTValue->Clone());
                 }
             }
             if (pFieldDict->KeyExist(FX_BSTRC("Ff"))) {
                 CPDF_Object *pFfValue = pFieldDict->GetElementValue(FX_BSTRC("Ff"));
                 if (pFfValue) {
                     pParent->SetAt(FX_BSTRC("Ff"), pFfValue->Clone());
                 }
             }
         }
-        pField = FX_NEW CPDF_FormField(this, pParent);
+        pField = new CPDF_FormField(this, pParent);
         CPDF_Object* pTObj = pDict->GetElement("T");
         if (pTObj && pTObj->GetType() == PDFOBJ_REFERENCE) {
             CPDF_Object* pClone = pTObj->Clone(TRUE);
             if (pClone) {
                 pDict->SetAt("T", pClone);
             } else {
                 pDict->SetAtName("T", "");
             }
         }
         m_pFieldTree->SetField(csWName, pField);
@@ skipping 16 matching lines @@
         }
     }
     return pField;
 }
 CPDF_FormControl* CPDF_InterForm::AddControl(const CPDF_FormField* pField, const CPDF_Dictionary* pWidgetDict)
 {
     void *rValue = NULL;
     if (m_ControlMap.Lookup((CPDF_Dictionary*)pWidgetDict, rValue)) {
         return (CPDF_FormControl*)rValue;
     }
-    CPDF_FormControl* pControl = FX_NEW CPDF_FormControl((CPDF_FormField*)pField, (CPDF_Dictionary*)pWidgetDict);
-    if (pControl == NULL) {
-        return NULL;
-    }
+    CPDF_FormControl* pControl = new CPDF_FormControl((CPDF_FormField*)pField, (CPDF_Dictionary*)pWidgetDict);
     m_ControlMap.SetAt((CPDF_Dictionary*)pWidgetDict, pControl);
     ((CPDF_FormField*)pField)->m_ControlList.Add(pControl);
     return pControl;
 }
 CPDF_FormField* CPDF_InterForm::CheckRequiredFields(const CFX_PtrArray *fields, FX_BOOL bIncludeOrExclude) const
 {
     int nCount = m_pFieldTree->m_Root.CountFields();
     for (int i = 0; i < nCount; i++) {
         CPDF_FormField* pField = m_pFieldTree->m_Root.GetField(i);
         if (pField == NULL) {
@@ skipping 267 matching lines @@
                 continue;
             }
             CPDF_FormControl* pControl = NULL;
             if (m_ControlMap.Lookup(pAnnotDict, (void*&)pControl)) {
                 return iNewPage;
             }
         }
     } while (TRUE);
     return -1;
 }