Revert of DevTools: [console] Logged promise rejections do not change state once handled

Source/devtools/front_end/console/ConsoleView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 118 matching lines @@
 
     this._registerShortcuts();
 
     this._messagesElement.addEventListener("contextmenu", this._handleContextMenuEvent.bind(this), false);
     WebInspector.moduleSetting("monitoringXHREnabled").addChangeListener(this._monitoringXHREnabledSettingChanged, this);
 
     this._linkifier = new WebInspector.Linkifier();
 
     /** @type {!Array.<!WebInspector.ConsoleViewMessage>} */
     this._consoleMessages = [];
-    this._viewMessageSymbol = Symbol("viewMessage");
 
     this._prompt = new WebInspector.TextPromptWithHistory(WebInspector.ExecutionContextSelector.completionsForTextPromptInCurrentContext);
     this._prompt.setSuggestBoxEnabled(true);
     this._prompt.setAutocompletionTimeout(0);
     this._prompt.renderAsBlock();
     var proxyElement = this._prompt.attach(this._promptElement);
     proxyElement.addEventListener("keydown", this._promptKeyDown.bind(this), false);
 
     this._consoleHistorySetting = WebInspector.settings.createLocalSetting("consoleHistory", []);
     var historyData = this._consoleHistorySetting.get();
@@ skipping 50 matching lines @@
         if (resourceTreeModel.target() !== WebInspector.targetManager.mainTarget())
             return;
         WebInspector.targetManager.removeModelListener(WebInspector.ResourceTreeModel, WebInspector.ResourceTreeModel.EventTypes.CachedResourcesLoaded, this._onResourceTreeModelLoaded, this);
         this._fetchMultitargetMessages();
     },
 
     _fetchMultitargetMessages: function()
     {
         WebInspector.multitargetConsoleModel.addEventListener(WebInspector.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this);
         WebInspector.multitargetConsoleModel.addEventListener(WebInspector.ConsoleModel.Events.MessageAdded, this._onConsoleMessageAdded, this);
-        WebInspector.multitargetConsoleModel.addEventListener(WebInspector.ConsoleModel.Events.MessageUpdated, this._onConsoleMessageUpdated, this);
         WebInspector.multitargetConsoleModel.addEventListener(WebInspector.ConsoleModel.Events.CommandEvaluated, this._commandEvaluated, this);
         WebInspector.multitargetConsoleModel.messages().forEach(this._addConsoleMessage, this);
     },
 
     /**
      * @override
      * @return {number}
      */
     itemCount: function()
     {
@@ skipping 334 matching lines @@
          * @return {number}
          */
         function compareTimestamps(viewMessage1, viewMessage2)
         {
             return WebInspector.ConsoleMessage.timestampComparator(viewMessage1.consoleMessage(), viewMessage2.consoleMessage());
         }
 
         if (message.type === WebInspector.ConsoleMessage.MessageType.Command || message.type === WebInspector.ConsoleMessage.MessageType.Result)
             message.timestamp = this._consoleMessages.length ? this._consoleMessages.peekLast().consoleMessage().timestamp : 0;
         var viewMessage = this._createViewMessage(message);
-        message[this._viewMessageSymbol] = viewMessage;
         var insertAt = insertionIndexForObjectInListSortedByFunction(viewMessage, this._consoleMessages, compareTimestamps, true);
         var insertedInMiddle = insertAt < this._consoleMessages.length;
         this._consoleMessages.splice(insertAt, 0, viewMessage);
 
         if (this._urlToMessageCount[message.url])
             ++this._urlToMessageCount[message.url];
         else
             this._urlToMessageCount[message.url] = 1;
 
         if (!insertedInMiddle) {
             this._appendMessageToEnd(viewMessage);
             this._updateFilterStatus();
             this._searchableView.updateSearchMatchesCount(this._regexMatchRanges.length);
         } else {
             this._needsFullUpdate = true;
         }
 
         this._scheduleViewportRefresh();
         this._consoleMessageAddedForTest(viewMessage);
     },
 
     /**
-     * @param {!WebInspector.Event} event
-     */
-    _onConsoleMessageUpdated: function(event)
-    {
-        var message = /** @type {!WebInspector.ConsoleMessage} */ (event.data);
-        var viewMessage = message[this._viewMessageSymbol];
-        if (viewMessage) {
-            viewMessage.updateMessageElement();
-            this._updateMessageList();
-        }
-    },
-
-    /**
      * @param {!WebInspector.ConsoleViewMessage} viewMessage
      */
     _consoleMessageAddedForTest: function(viewMessage) { },
 
     /**
      * @param {!WebInspector.ConsoleViewMessage} viewMessage
      */
     _appendMessageToEnd: function(viewMessage)
     {
         if (!this._filter.shouldBeVisible(viewMessage)) {
@@ skipping 554 matching lines @@
 };
 
 WebInspector.ConsoleViewFilter.prototype = {
     addFilters: function(filterBar)
     {
         this._textFilterUI = new WebInspector.TextFilterUI(true);
         this._textFilterUI.addEventListener(WebInspector.FilterUI.Events.FilterChanged, this._textFilterChanged, this);
         filterBar.addFilter(this._textFilterUI);
 
         var levels = [
-            {name: WebInspector.ConsoleMessage.MessageLevel.Error, label: WebInspector.UIString("Errors")},
-            {name: WebInspector.ConsoleMessage.MessageLevel.Warning, label: WebInspector.UIString("Warnings")},
-            {name: WebInspector.ConsoleMessage.MessageLevel.Info, label: WebInspector.UIString("Info")},
-            {name: WebInspector.ConsoleMessage.MessageLevel.Log, label: WebInspector.UIString("Logs")},
-            {name: WebInspector.ConsoleMessage.MessageLevel.Debug, label: WebInspector.UIString("Debug")},
-            {name: WebInspector.ConsoleMessage.MessageLevel.RevokedError, label: WebInspector.UIString("Handled")}
+            {name: "error", label: WebInspector.UIString("Errors")},
+            {name: "warning", label: WebInspector.UIString("Warnings")},
+            {name: "info", label: WebInspector.UIString("Info")},
+            {name: "log", label: WebInspector.UIString("Logs")},
+            {name: "debug", label: WebInspector.UIString("Debug")}
         ];
         this._levelFilterUI = new WebInspector.NamedBitSetFilterUI(levels, this._messageLevelFiltersSetting);
         this._levelFilterUI.addEventListener(WebInspector.FilterUI.Events.FilterChanged, this._filterChanged, this);
         filterBar.addFilter(this._levelFilterUI);
         this._hideNetworkMessagesCheckbox = new WebInspector.CheckboxFilterUI("hide-network-messages", WebInspector.UIString("Hide network messages"), true, WebInspector.moduleSetting("hideNetworkMessages"));
         this._hideNetworkMessagesCheckbox.addEventListener(WebInspector.FilterUI.Events.FilterChanged, this._filterChanged.bind(this), this);
         filterBar.addFilter(this._hideNetworkMessagesCheckbox);
     },
 
     _textFilterChanged: function(event)
@@ skipping 244 matching lines @@
     handleAction: function(context, actionId)
     {
         WebInspector.console.show();
     }
 }
 
 /**
 * @typedef {{messageIndex: number, matchIndex: number}}
 */
 WebInspector.ConsoleView.RegexMatchRange;