Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1090583005: Revert of DevTools: [console] Logged promise rejections do not change state once handled (Closed)

Created:
5 years, 8 months ago by alancutter (OOO until 2018)
Modified:
5 years, 8 months ago
Reviewers:
kozy, dgozman, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, vivekg, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews-bindings_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of DevTools: [console] Logged promise rejections do not change state once handled (patchset #13 id:240001 of https://codereview.chromium.org/1095943002/) Reason for revert: The following tests were made leaky due to this change: virtual/slimmingpaint/fast/css/fontfaceset-add-remove-while-loading.html inspector/console/console-revoke-error.html inspector/console/console-uncaught-promise.html inspector/sources/debugger/debugger-uncaught-promise-on-pause.html inspector/sources/debugger/debugger-pause-on-promise-rejection.html fast/css/fontfaceset-add-remove-while-loading.html http/tests/serviceworker/fetch-request-resources.html http/tests/fetch/window/fetch-base-https-other-https.html http/tests/fetch/window/fetch.html inspector-enabled/console/console-uncaught-promise-no-inspector.html web-animations-api/player-finished-promise.html web-animations-api/player-ready-promise.html http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/10612 Confirmed with manual bisect. Original issue's description: > DevTools: [console] Logged promise rejections do not change state once handled > > BUG=477557 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194136 TBR=dgozman@chromium.org,sergeyv@chromium.org,kozyatinskiy@chromium.org,pfeldman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477557 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194264

Patch Set 1 #

Patch Set 2 : Encompass Oilpan fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -464 lines) Patch
M LayoutTests/http/tests/inspector/console-test.js View 1 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/inspector/console/console-revoke-error.html View 1 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/inspector/console/console-revoke-error-expected.txt View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/inspector/console/console-revoke-error-in-worker.html View 1 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/inspector/console/console-revoke-error-in-worker-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/inspector/console/resources/worker-with-defer-handled-promise.js View 1 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/promise-pane-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/RejectedPromises.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/bindings/core/v8/RejectedPromises.cpp View 1 6 chunks +1 line, -51 lines 0 comments Download
M Source/bindings/core/v8/V8Initializer.cpp View 1 4 chunks +6 lines, -15 lines 0 comments Download
M Source/core/frame/ConsoleTypes.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.cpp View 1 3 chunks +0 lines, -20 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/Images/src/optimize_png.hashes View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Images/src/svg2png.hashes View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Images/src/toolbarButtonGlyphs.svg View 1 3 chunks +6 lines, -35 lines 0 comments Download
M Source/devtools/front_end/Images/toolbarButtonGlyphs.png View 1 Binary file 0 comments Download
M Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png View 1 Binary file 0 comments Download
M Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 5 chunks +5 lines, -22 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 7 chunks +13 lines, -22 lines 0 comments Download
M Source/devtools/front_end/console/consoleView.css View 1 6 chunks +2 lines, -9 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 chunks +5 lines, -9 lines 0 comments Download
M Source/devtools/front_end/sdk/ConsoleModel.js View 1 13 chunks +34 lines, -76 lines 0 comments Download
M Source/devtools/front_end/ui/smallIcon.css View 1 3 chunks +0 lines, -6 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 chunks +2 lines, -4 lines 0 comments Download
M public/web/WebConsoleMessage.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
alancutter (OOO until 2018)
Created Revert of DevTools: [console] Logged promise rejections do not change state once handled
5 years, 8 months ago (2015-04-23 05:08:48 UTC) #1
pfeldman
Could you suppress it and file a bug? I'll follow up shortly.
5 years, 8 months ago (2015-04-23 05:17:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090583005/280001
5 years, 8 months ago (2015-04-23 05:18:02 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 05:18:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:280001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194264

Powered by Google App Engine
This is Rietveld 408576698