Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090423007: Serialize <string> with double quotes (Closed)

Created:
5 years, 8 months ago by rwlbuis
Modified:
5 years, 8 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Serialize <string> with double quotes Serialize <string> with double quotes by calling serializeString. This is described in the spec here: http://dev.w3.org/csswg/cssom/#serialize-a-string Adapt the tests to handle this new behavior. Behavior matches Firefox. BUG=478775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194401

Patch Set 1 #

Patch Set 2 : Fix more tests #

Total comments: 1

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -230 lines) Patch
M LayoutTests/css3/supports.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/supports-expected.txt View 1 2 1 chunk +48 lines, -48 lines 0 comments Download
M LayoutTests/fast/css/content-language-case-insensitivity.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/content-language-case-insensitivity-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/content-language-comma-separated-list.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/content-language-comma-separated-list-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-dynamically-added.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/content-language-dynamically-added-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/content-language-dynamically-changed.html View 1 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css/content-language-dynamically-changed-expected.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/css/content-language-dynamically-removed.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/content-language-dynamically-removed-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/content-language-empty.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/content-language-empty-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-late.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-late-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-mapped-to-webkit-locale.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-mapped-to-webkit-locale-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-multiple.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-multiple-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-no-content.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/content-language-no-content-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/content-language-only-whitespace.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/content-language-only-whitespace-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-with-whitespace.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-language-with-whitespace-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/content-property-serialization.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/csstext-of-content-string.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/csstext-of-content-string-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-properties.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-properties-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/lang-mapped-to-webkit-locale.xhtml View 1 1 chunk +19 lines, -19 lines 0 comments Download
M LayoutTests/fast/css/lang-mapped-to-webkit-locale-dynamic.xhtml View 1 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/css/lang-mapped-to-webkit-locale-dynamic-expected.txt View 1 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/css/lang-mapped-to-webkit-locale-expected.txt View 1 1 chunk +19 lines, -19 lines 0 comments Download
M LayoutTests/fast/css/nested-at-rules.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/nested-at-rules-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/parsing-text-emphasis.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/parsing-text-emphasis-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/xml-lang-ignored-in-html.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/xml-lang-ignored-in-html-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/hover-after-dom-delete.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/hover-after-dom-delete-child-invisible-cursor.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/hover-after-dom-delete-child-invisible-cursor-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/hover-after-dom-delete-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/css-charset-default-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/misc/extract-http-content-language.php View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/extract-http-content-language-against-equiv.php View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/extract-http-content-language-against-equiv-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/extract-http-content-language-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/extract-http-content-language-malformed.php View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/extract-http-content-language-malformed-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/extract-http-content-language-multiple.php View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/extract-http-content-language-multiple-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rwlbuis
PTAL. Looks like I missed one test but that should be an easy fix.
5 years, 8 months ago (2015-04-24 00:58:11 UTC) #2
Timothy Loh
https://codereview.chromium.org/1090423007/diff/20001/LayoutTests/fast/css/getComputedStyle/computed-style-properties.html File LayoutTests/fast/css/getComputedStyle/computed-style-properties.html (right): https://codereview.chromium.org/1090423007/diff/20001/LayoutTests/fast/css/getComputedStyle/computed-style-properties.html#newcode69 LayoutTests/fast/css/getComputedStyle/computed-style-properties.html:69: shouldBe("computedStyleFor('content', 'after', 'content')", '\"test \" url(data:image/gif;base64,R0lGODlhAQABAJAAAP8AAAAAACwAAAAAAQABAAACAgQBADs=)'); Maybe you want ...
5 years, 8 months ago (2015-04-24 10:23:58 UTC) #3
Timothy Loh
lgtm
5 years, 8 months ago (2015-04-24 10:24:00 UTC) #4
Timothy Loh
Spec link in description would be good.
5 years, 8 months ago (2015-04-24 12:15:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090423007/40001
5 years, 8 months ago (2015-04-24 15:00:14 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 16:00:05 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194401

Powered by Google App Engine
This is Rietveld 408576698