LayoutTests/http/tests/misc/extract-http-content-language-malformed.php - Issue 1090423007: Serialize <string> with double quotes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/misc/extract-http-content-language-malformed.php

Issue 1090423007: Serialize <string> with double quotes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/misc/extract-http-content-language-expected.txt ('k') | LayoutTests/http/tests/misc/extract-http-content-language-malformed-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/misc/extract-http-content-language-malformed.php

diff --git a/LayoutTests/http/tests/misc/extract-http-content-language-malformed.php b/LayoutTests/http/tests/misc/extract-http-content-language-malformed.php

index 10e882d5f9aff72f7aec4c1f6e155517a2ceb750..b55499ca7b5034e3f11432163a200a2834386049 100644

--- a/LayoutTests/http/tests/misc/extract-http-content-language-malformed.php

+++ b/LayoutTests/http/tests/misc/extract-http-content-language-malformed.php

@@ -16,9 +16,9 @@ Extract HTTP Content-Language header.</p>

debug('==> Value extracted from malformed HTTP "Content-Language" header...');

// A malformed header may be fixed by the browser ("es") or left bad and so remain unset ("auto").

// Chrome does the former; Safari does the latter.

- shouldBeTrue('window.getComputedStyle(document.getElementById("x")).webkitLocale == "\'es\'" || window.getComputedStyle(document.getElementById("x")).webkitLocale == "auto"')

+ shouldBeTrue('window.getComputedStyle(document.getElementById("x")).webkitLocale == \'"es"\' || window.getComputedStyle(document.getElementById("x")).webkitLocale == "auto"')

debug('==> Value set by div "lang" tag...');

- shouldBe('window.getComputedStyle(document.getElementById("y")).webkitLocale', '"\'ar\'"')

+ shouldBe('window.getComputedStyle(document.getElementById("y")).webkitLocale', "'\"ar\"'")

debug('==> All done...');

</script>

</body>