Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7107)

Unified Diff: chrome/browser/sync_file_system/sync_file_system_service.cc

Issue 1090413003: [chrome/browser/sync && sync_file_system] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed build breaks Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync_file_system/local/local_file_sync_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/sync_file_system_service.cc
diff --git a/chrome/browser/sync_file_system/sync_file_system_service.cc b/chrome/browser/sync_file_system/sync_file_system_service.cc
index 777c8c5b3b3b1776f1a30677694e69a95c3b2098..804eccfa9cd21828260e59cbffc494b210366392 100644
--- a/chrome/browser/sync_file_system/sync_file_system_service.cc
+++ b/chrome/browser/sync_file_system/sync_file_system_service.cc
@@ -158,7 +158,7 @@ class LocalSyncRunner : public SyncProcessRunner,
// LocalFileSyncService::Observer overrides.
void OnLocalChangeAvailable(int64 pending_changes) override {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
OnChangesUpdated(pending_changes);
@@ -208,7 +208,7 @@ class RemoteSyncRunner : public SyncProcessRunner,
// RemoteFileSyncService::Observer overrides.
void OnRemoteChangeQueueUpdated(int64 pending_changes) override {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
OnChangesUpdated(pending_changes);
@@ -251,7 +251,7 @@ class RemoteSyncRunner : public SyncProcessRunner,
// SyncFileSystemService
void SyncFileSystemService::Shutdown() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
local_sync_runners_.clear();
remote_sync_runners_.clear();
@@ -272,7 +272,7 @@ void SyncFileSystemService::Shutdown() {
}
SyncFileSystemService::~SyncFileSystemService() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(!profile_);
}
@@ -446,7 +446,7 @@ SyncFileSystemService::SyncFileSystemService(Profile* profile)
void SyncFileSystemService::Initialize(
scoped_ptr<LocalFileSyncService> local_service,
scoped_ptr<RemoteFileSyncService> remote_service) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(local_service);
DCHECK(remote_service);
DCHECK(profile_);
@@ -635,7 +635,7 @@ void SyncFileSystemService::DidGetLocalChangeStatus(
void SyncFileSystemService::OnRemoteServiceStateUpdated(
RemoteServiceState state,
const std::string& description) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
util::Log(logging::LOG_VERBOSE, FROM_HERE,
"OnRemoteServiceStateChanged: %d %s", state, description.c_str());
« no previous file with comments | « chrome/browser/sync_file_system/local/local_file_sync_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698