Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1090373002: Remove build step that escapes unicode in autofill_regex_constants.cc (Closed)

Created:
5 years, 8 months ago by Evan Stade
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove build step that escapes unicode in autofill_regex_constants.cc Just put the unicode directly into the .cc file. I'm not sure when this became possible, but we have tests that put unicode directly in string literals without escaping. BUG=478334 Committed: https://crrev.com/ef2d6eb985b01fe0df168aa6c4cc8d8d8eac73b2 Cr-Commit-Position: refs/heads/master@{#325918}

Patch Set 1 #

Patch Set 2 : fix GN #

Patch Set 3 : fix gn more #

Patch Set 4 : also remove python script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -405 lines) Patch
D build/escape_unicode.py View 1 2 3 1 chunk +0 lines, -56 lines 0 comments Download
M components/autofill.gypi View 5 chunks +1 line, -26 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 2 4 chunks +1 line, -24 lines 0 comments Download
A + components/autofill/core/browser/autofill_regex_constants.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D components/autofill/core/browser/autofill_regex_constants.cc.utf8 View 1 chunk +0 lines, -299 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
5 years, 8 months ago (2015-04-20 17:39:34 UTC) #2
brettw
lgtm
5 years, 8 months ago (2015-04-20 19:26:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090373002/60001
5 years, 8 months ago (2015-04-20 20:38:10 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-20 22:05:24 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 22:06:18 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ef2d6eb985b01fe0df168aa6c4cc8d8d8eac73b2
Cr-Commit-Position: refs/heads/master@{#325918}

Powered by Google App Engine
This is Rietveld 408576698