Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: components/autofill.gypi

Issue 1090373002: Remove build step that escapes unicode in autofill_regex_constants.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: also remove python script Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/escape_unicode.py ('k') | components/autofill/content/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill.gypi
diff --git a/components/autofill.gypi b/components/autofill.gypi
index a9ae29c4af44dc97685af16c6f7577388ad9744f..f3d2f6a76d90a15c27487d3487fc1c6ac3d3e7d1 100644
--- a/components/autofill.gypi
+++ b/components/autofill.gypi
@@ -5,26 +5,6 @@
{
'targets': [
{
- # Private target only used in components/autofill.
- # GN version: //components/autofill/core/browser:regexes
- 'target_name': 'autofill_regexes',
- 'type': 'none',
- 'actions': [{
- 'action_name': 'autofill_regexes',
- 'inputs': [
- '<(DEPTH)/build/escape_unicode.py',
- 'autofill/core/browser/autofill_regex_constants.cc.utf8',
- ],
- 'outputs': [
- '<(SHARED_INTERMEDIATE_DIR)/autofill_regex_constants.cc',
- ],
- 'action': ['python', '<(DEPTH)/build/escape_unicode.py',
- '-o', '<(SHARED_INTERMEDIATE_DIR)',
- 'autofill/core/browser/autofill_regex_constants.cc.utf8'],
- }],
- },
-
- {
# GN version: //components/autofill/core/common
'target_name': 'autofill_core_common',
'type': 'static_library',
@@ -97,7 +77,6 @@
'../ui/gfx/gfx.gyp:gfx_geometry',
'../url/url.gyp:url_lib',
'autofill_core_common',
- 'autofill_regexes',
'components_resources.gyp:components_resources',
'components_strings.gyp:components_strings',
'infobars_core',
@@ -145,7 +124,7 @@
'autofill/core/browser/autofill_popup_delegate.h',
'autofill/core/browser/autofill_profile.cc',
'autofill/core/browser/autofill_profile.h',
- 'autofill/core/browser/autofill_regex_constants.cc.utf8',
+ 'autofill/core/browser/autofill_regex_constants.cc',
'autofill/core/browser/autofill_regex_constants.h',
'autofill/core/browser/autofill_regexes.cc',
'autofill/core/browser/autofill_regexes.h',
@@ -222,9 +201,6 @@
'autofill/core/browser/webdata/autofill_webdata_service.cc',
'autofill/core/browser/webdata/autofill_webdata_service.h',
'autofill/core/browser/webdata/autofill_webdata_service_observer.h',
-
- # This file is generated by the autofill_regexes action.
- '<(SHARED_INTERMEDIATE_DIR)/autofill_regex_constants.cc',
],
'conditions': [
['desktop_linux==1', {
@@ -361,7 +337,6 @@
'autofill_content_risk_proto',
'autofill_core_browser',
'autofill_core_common',
- 'autofill_regexes',
'components_resources.gyp:components_resources',
'components_strings.gyp:components_strings',
'os_crypt',
« no previous file with comments | « build/escape_unicode.py ('k') | components/autofill/content/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698