Issue 1090323003: [chrome/browser/download] favor DCHECK_CURRENTLY_ON for better logs

Issue 1090323003: [chrome/browser/download] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 8 months ago

Reviewers:
asanka

CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/download BUG=466848 Committed: https://crrev.com/abc35582397a3d44bdb03d3c3071f46ec4db32eb Cr-Commit-Position: refs/heads/master@{#326839}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -92 lines)			Patch
M	chrome/browser/download/chrome_download_manager_delegate.cc	View	14 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/download/download_crx_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_history.cc	View	9 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/download/download_history_unittest.cc	View	9 chunks	+29 lines, -29 lines	0 comments	Download
M	chrome/browser/download/download_path_reservation_tracker.cc	View	7 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/download/download_request_limiter.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/download/download_target_determiner.cc	View	25 chunks	+25 lines, -25 lines	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2015/04/24 15:49:00, asanka wrote: > lgtm Thankd asanka for lgtm

5 years, 8 months ago (2015-04-24 17:18:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090323003/1

5 years, 8 months ago (2015-04-24 17:19:56 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 18:10:09 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/abc35582397a3d44bdb03d3c3071f46ec4db32eb
Cr-Commit-Position: refs/heads/master@{#326839}