chrome/browser/download/download_request_limiter.cc - Issue 1090323003: [chrome/browser/download] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_request_limiter.cc

Issue 1090323003: [chrome/browser/download] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_path_reservation_tracker.cc ('k') | chrome/browser/download/download_target_determiner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_request_limiter.cc

diff --git a/chrome/browser/download/download_request_limiter.cc b/chrome/browser/download/download_request_limiter.cc

index 9d2117d6c15f243758e21179371a53389004ce26..39e3cd0a3b47a527ddbd7c773f1edbfaf3aa824c 100644

--- a/chrome/browser/download/download_request_limiter.cc

+++ b/chrome/browser/download/download_request_limiter.cc

@@ -287,7 +287,7 @@ void DownloadRequestLimiter::CanDownloadOnIOThread(

const Callback& callback) {

// This is invoked on the IO thread. Schedule the task to run on the UI

// thread so that we can query UI state.

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

base::Bind(&DownloadRequestLimiter::CanDownload, this,

@@ -319,7 +319,7 @@ void DownloadRequestLimiter::CanDownload(int render_process_host_id,

const GURL& url,

const std::string& request_method,

const Callback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

content::WebContents* originating_contents =

tab_util::GetWebContentsByID(render_process_host_id, render_view_id);

@@ -357,7 +357,7 @@ void DownloadRequestLimiter::OnCanDownloadDecided(

int render_view_id,

const std::string& request_method,

const Callback& orig_callback, bool allow) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

content::WebContents* originating_contents =

tab_util::GetWebContentsByID(render_process_host_id, render_view_id);

if (!originating_contents || !allow) {