Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: components/nacl/common/nacl_renderer_messages.h

Issue 1090233003: Set up a NaCl load status callback to start replacing "start_module". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add back old comment Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/nacl/loader/nacl_listener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/common/nacl_renderer_messages.h
diff --git a/components/nacl/common/nacl_renderer_messages.h b/components/nacl/common/nacl_renderer_messages.h
index e07a08267ddb900e1f0c878631c7e2599a5d0196..38da59cf4b2169458fa9a93bb0859b9c26f87795 100644
--- a/components/nacl/common/nacl_renderer_messages.h
+++ b/components/nacl/common/nacl_renderer_messages.h
@@ -13,3 +13,8 @@
// NaCl to the renderer before the NaCl process exits very soon after.
IPC_SYNC_MESSAGE_CONTROL1_0(NaClRendererMsg_ReportExitStatus,
int /* exit_status */)
+
+// This message must be synchronous to ensure that the load status is sent from
+// NaCl to the renderer before the NaCl process exits very soon after.
+IPC_SYNC_MESSAGE_CONTROL1_0(NaClRendererMsg_ReportLoadStatus,
+ int /* load_status */)
Will Harris 2015/04/22 00:41:01 Any reason why you use int here? This should be e
jvoung (off chromium) 2015/04/22 21:45:21 Done.
« no previous file with comments | « no previous file | components/nacl/loader/nacl_listener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698