Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: components/nacl/common/nacl_renderer_messages.h

Issue 1090233003: Set up a NaCl load status callback to start replacing "start_module". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add back old comment Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/nacl/loader/nacl_listener.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Defines messages between the renderer and the NaCl process. 5 // Defines messages between the renderer and the NaCl process.
6 6
7 // Multiply-included message file, no traditional include guard. 7 // Multiply-included message file, no traditional include guard.
8 #include "ipc/ipc_message_macros.h" 8 #include "ipc/ipc_message_macros.h"
9 9
10 #define IPC_MESSAGE_START NaClHostMsgStart 10 #define IPC_MESSAGE_START NaClHostMsgStart
11 11
12 // This message must be synchronous to ensure that the exit status is sent from 12 // This message must be synchronous to ensure that the exit status is sent from
13 // NaCl to the renderer before the NaCl process exits very soon after. 13 // NaCl to the renderer before the NaCl process exits very soon after.
14 IPC_SYNC_MESSAGE_CONTROL1_0(NaClRendererMsg_ReportExitStatus, 14 IPC_SYNC_MESSAGE_CONTROL1_0(NaClRendererMsg_ReportExitStatus,
15 int /* exit_status */) 15 int /* exit_status */)
16
17 // This message must be synchronous to ensure that the load status is sent from
18 // NaCl to the renderer before the NaCl process exits very soon after.
19 IPC_SYNC_MESSAGE_CONTROL1_0(NaClRendererMsg_ReportLoadStatus,
20 int /* load_status */)
Will Harris 2015/04/22 00:41:01 Any reason why you use int here? This should be e
jvoung (off chromium) 2015/04/22 21:45:21 Done.
OLDNEW
« no previous file with comments | « no previous file | components/nacl/loader/nacl_listener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698