[release-tools] Chrome V8 version is now converted to real V8 version

tools/release/releases.py

Index: tools/release/releases.py
diff --git a/tools/release/releases.py b/tools/release/releases.py
index a82da2bddf5aaec98fc9518180fc47297093f9d2..05d83ced6bfa939e0d45de0150adf4c6029e2525 100755
--- a/tools/release/releases.py
+++ b/tools/release/releases.py
@@ -460,11 +460,10 @@ class RetrieveInformationOnChromeReleases(Step):
     chrome_releases = {"canaries": canaries}
     self["chrome_releases"] = chrome_releases
 
-  def _GetGitHashForV8Version(self, v8_version):
+  def _ConvertToRealV8Version(self, v8_version):
     if v8_version.split(".")[3]== "0":

[Michael Achenbach, 2015/04/17 13:23:09]

nit: space before ==

[Michael Hablich, 2015/04/20 12:29:34]

Acknowledged.

[Michael Achenbach, 2015/04/28 20:48:49]

Acknowledged but not resolved?

-      return self.GitGetHashOfTag(v8_version[:-2])
-
-    return self.GitGetHashOfTag(v8_version)
+      return v8_version[:-2]
+    return v8_version
 
   def _CreateCandidate(self, current_version):
     params = None
@@ -475,11 +474,13 @@ class RetrieveInformationOnChromeReleases(Step):
                          params,
                          wait_plan=[5, 20]
                          )
-    previous_v8_version = json.loads(result_raw)["v8_version"]
-    v8_previous_version_hash = self._GetGitHashForV8Version(previous_v8_version)
+    previous_v8_version = (
+      self._ConvertToRealV8Version(json.loads(result_raw)["v8_version"]))
+    v8_previous_version_hash = self.GitGetHashOfTag(previous_v8_version)
 
-    current_v8_version = current_version["v8_version"]
-    v8_version_hash = self._GetGitHashForV8Version(current_v8_version)
+    current_v8_version = (
+      self._ConvertToRealV8Version(current_version["v8_version"]))
+    v8_version_hash = self.GitGetHashOfTag(current_v8_version)
 
     current_candidate = {
                         "chrome_version": current_version["version"],