Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1089893002: Debugger: clean up debug events. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: clean up debug events. The debug event BreakForCommand is now deprecated, as it cannot happen any longer. R=ulan@chromium.org Committed: https://crrev.com/10b979e6aaf9b39867497773b09c28aea9a71620 Cr-Commit-Position: refs/heads/master@{#28071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M include/v8-debug.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M src/debug-debugger.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Yang
5 years, 8 months ago (2015-04-16 13:23:33 UTC) #1
Yang
On 2015/04/16 13:23:33, Yang wrote: ping
5 years, 8 months ago (2015-04-17 11:54:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089893002/1
5 years, 8 months ago (2015-04-17 13:05:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-17 13:45:59 UTC) #6
Yang
On 2015/04/17 13:45:59, I haz the power (commit-bot) wrote: > Dry run: This issue passed ...
5 years, 8 months ago (2015-04-20 06:42:37 UTC) #7
Yang
On 2015/04/20 06:42:37, Yang wrote: > On 2015/04/17 13:45:59, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-23 13:28:40 UTC) #8
ulan
lgtm if you add comment in description about breaking API change.
5 years, 8 months ago (2015-04-24 14:39:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089893002/1
5 years, 8 months ago (2015-04-27 10:51:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/4210)
5 years, 8 months ago (2015-04-27 11:06:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089893002/1
5 years, 8 months ago (2015-04-27 11:46:54 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 12:10:28 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 12:10:41 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10b979e6aaf9b39867497773b09c28aea9a71620
Cr-Commit-Position: refs/heads/master@{#28071}

Powered by Google App Engine
This is Rietveld 408576698