Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: src/debug.cc

Issue 1089893002: Debugger: clean up debug events. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8-debug.h ('k') | src/debug-debugger.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 25407a746fc5a61b6e58e7e2fd1367427bb160f3..e6077d1deeb577aa0c473033b22c9644501755c8 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -2824,21 +2824,18 @@ void Debug::NotifyMessageHandler(v8::DebugEvent event,
bool sendEventMessage = false;
switch (event) {
case v8::Break:
- case v8::BreakForCommand:
sendEventMessage = !auto_continue;
break;
- case v8::Exception:
- sendEventMessage = true;
- break;
+ case v8::NewFunction:
case v8::BeforeCompile:
+ case v8::CompileError:
+ case v8::PromiseEvent:
+ case v8::AsyncTaskEvent:
break;
+ case v8::Exception:
case v8::AfterCompile:
sendEventMessage = true;
break;
- case v8::NewFunction:
- break;
- default:
- UNREACHABLE();
}
// The debug command interrupt flag might have been set when the command was
« no previous file with comments | « include/v8-debug.h ('k') | src/debug-debugger.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698