Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: Source/bindings/templates/interface_base.cpp

Issue 1089833003: make V8Window named interceptor non-masking (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/interface_base.cpp
diff --git a/Source/bindings/templates/interface_base.cpp b/Source/bindings/templates/interface_base.cpp
index ea5c732e40872d01d3d2a217d839c10bde592e0b..2ffc4c8176d1363d3c9d30fb5d10092eccf0a0c3 100644
--- a/Source/bindings/templates/interface_base.cpp
+++ b/Source/bindings/templates/interface_base.cpp
@@ -393,15 +393,11 @@ static void install{{v8_class}}Template(v8::Local<v8::FunctionTemplate> function
if named_property_getter.is_enumerable else '0' %}
{
v8::NamedPropertyHandlerConfiguration config({{named_property_getter_callback}}, {{named_property_setter_callback}}, {{named_property_query_callback}}, {{named_property_deleter_callback}}, {{named_property_enumerator_callback}});
- {# TODO(yukishiino): Determine how to treat Window interface. #}
- {% if interface_name != 'Window' %}
config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(config.flags) | static_cast<int>(v8::PropertyHandlerFlags::kOnlyInterceptStrings));
- {% endif %}
{% if named_property_getter.do_not_check_security %}
config.flags = v8::PropertyHandlerFlags::kAllCanRead;
{% endif %}
- {# TODO(yukishiino): Determine how to treat Window interface. #}
- {% if not is_override_builtins and interface_name != 'Window' %}
+ {% if not is_override_builtins %}
config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(config.flags) | static_cast<int>(v8::PropertyHandlerFlags::kNonMasking));
{% endif %}
functionTemplate->{{set_on_template}}()->SetHandler(config);
« no previous file with comments | « Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698