Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: Source/bindings/templates/interface_base.cpp

Issue 1089833003: make V8Window named interceptor non-masking (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% include 'copyright_block.txt' %} 1 {% include 'copyright_block.txt' %}
2 #include "config.h" 2 #include "config.h"
3 {% filter conditional(conditional_string) %} 3 {% filter conditional(conditional_string) %}
4 #include "{{v8_class_or_partial}}.h" 4 #include "{{v8_class_or_partial}}.h"
5 5
6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %} 6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
7 #include "{{filename}}" 7 #include "{{filename}}"
8 {% endfor %} 8 {% endfor %}
9 9
10 namespace blink { 10 namespace blink {
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 '%sV8Internal::namedPropertyQueryCallback' % cpp_class 386 '%sV8Internal::namedPropertyQueryCallback' % cpp_class
387 if named_property_getter.is_enumerable else '0' %} 387 if named_property_getter.is_enumerable else '0' %}
388 {% set named_property_deleter_callback = 388 {% set named_property_deleter_callback =
389 '%sV8Internal::namedPropertyDeleterCallback' % cpp_class 389 '%sV8Internal::namedPropertyDeleterCallback' % cpp_class
390 if named_property_deleter else '0' %} 390 if named_property_deleter else '0' %}
391 {% set named_property_enumerator_callback = 391 {% set named_property_enumerator_callback =
392 '%sV8Internal::namedPropertyEnumeratorCallback' % cpp_class 392 '%sV8Internal::namedPropertyEnumeratorCallback' % cpp_class
393 if named_property_getter.is_enumerable else '0' %} 393 if named_property_getter.is_enumerable else '0' %}
394 { 394 {
395 v8::NamedPropertyHandlerConfiguration config({{named_property_getter_cal lback}}, {{named_property_setter_callback}}, {{named_property_query_callback}}, {{named_property_deleter_callback}}, {{named_property_enumerator_callback}}); 395 v8::NamedPropertyHandlerConfiguration config({{named_property_getter_cal lback}}, {{named_property_setter_callback}}, {{named_property_query_callback}}, {{named_property_deleter_callback}}, {{named_property_enumerator_callback}});
396 {# TODO(yukishiino): Determine how to treat Window interface. #}
397 {% if interface_name != 'Window' %}
398 config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(co nfig.flags) | static_cast<int>(v8::PropertyHandlerFlags::kOnlyInterceptStrings)) ; 396 config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(co nfig.flags) | static_cast<int>(v8::PropertyHandlerFlags::kOnlyInterceptStrings)) ;
399 {% endif %}
400 {% if named_property_getter.do_not_check_security %} 397 {% if named_property_getter.do_not_check_security %}
401 config.flags = v8::PropertyHandlerFlags::kAllCanRead; 398 config.flags = v8::PropertyHandlerFlags::kAllCanRead;
402 {% endif %} 399 {% endif %}
403 {# TODO(yukishiino): Determine how to treat Window interface. #} 400 {% if not is_override_builtins %}
404 {% if not is_override_builtins and interface_name != 'Window' %}
405 config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(co nfig.flags) | static_cast<int>(v8::PropertyHandlerFlags::kNonMasking)); 401 config.flags = static_cast<v8::PropertyHandlerFlags>(static_cast<int>(co nfig.flags) | static_cast<int>(v8::PropertyHandlerFlags::kNonMasking));
406 {% endif %} 402 {% endif %}
407 functionTemplate->{{set_on_template}}()->SetHandler(config); 403 functionTemplate->{{set_on_template}}()->SetHandler(config);
408 } 404 }
409 {% endif %} 405 {% endif %}
410 {% if iterator_method %} 406 {% if iterator_method %}
411 {% filter per_context_enabled(iterator_method.per_context_enabled_function) %} 407 {% filter per_context_enabled(iterator_method.per_context_enabled_function) %}
412 {% filter exposed(iterator_method.exposed_test) %} 408 {% filter exposed(iterator_method.exposed_test) %}
413 {% filter runtime_enabled(iterator_method.runtime_enabled_function) %} 409 {% filter runtime_enabled(iterator_method.runtime_enabled_function) %}
414 static const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedI teratorConfiguration = { v8::Symbol::GetIterator, {{cpp_class_or_partial}}V8Inte rnal::iteratorMethodCallback, 0, V8DOMConfiguration::ExposedToAllScripts }; 410 static const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedI teratorConfiguration = { v8::Symbol::GetIterator, {{cpp_class_or_partial}}V8Inte rnal::iteratorMethodCallback, 0, V8DOMConfiguration::ExposedToAllScripts };
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 {% endfor %} 497 {% endfor %}
502 {% for attribute in attributes if attribute.is_implemented_in_private_script %} 498 {% for attribute in attributes if attribute.is_implemented_in_private_script %}
503 {{attribute_getter_implemented_in_private_script(attribute)}} 499 {{attribute_getter_implemented_in_private_script(attribute)}}
504 {% if attribute.has_setter %} 500 {% if attribute.has_setter %}
505 {{attribute_setter_implemented_in_private_script(attribute)}} 501 {{attribute_setter_implemented_in_private_script(attribute)}}
506 {% endif %} 502 {% endif %}
507 {% endfor %} 503 {% endfor %}
508 {% block partial_interface %}{% endblock %} 504 {% block partial_interface %}{% endblock %}
509 } // namespace blink 505 } // namespace blink
510 {% endfilter %} 506 {% endfilter %}
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698