Introduce ChildScheduler as common base interface for WorkerScheduler and RendererScheduler.

Introduce ChildScheduler as common base interface for WorkerScheduler and RendererScheduler.

BUG=463143
Committed: https://crrev.com/d6fe37652cf1a317e050beb8ffec5209a4143473
Cr-Commit-Position: refs/heads/master@{#325433}

[rmcilroy, 2015-04-16 11:20:37]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[rmcilroy, 2015-04-16 11:20:59]

rmcilroy@chromium.org changed reviewers:
+ alexclarke@chromium.org, skyostil@chromium.org

[rmcilroy, 2015-04-16 11:20:59]

PTAL, thanks.

[commit-bot: I haz the power, 2015-04-16 11:21:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1089833002/1

[commit-bot: I haz the power, 2015-04-16 11:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 11:31:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alex clarke (OOO till 29th), 2015-04-16 11:32:06]

lgtm

Looks like I owe you a beer ;)

Only thing is comment nits re 'main thread'

https://codereview.chromium.org/1089833002/diff/1/content/child/scheduler/chi...
File content/child/scheduler/child_scheduler.h (right):

https://codereview.chromium.org/1089833002/diff/1/content/child/scheduler/chi...
content/child/scheduler/child_scheduler.h:30: // Returns true if there is high
priority work pending on the main thread
I wonder if we can avoid saying 'main thread'.  Perhaps 'thread this class was
created on'?

https://codereview.chromium.org/1089833002/diff/1/content/child/scheduler/chi...
content/child/scheduler/child_scheduler.h:44: // Must be called from the
scheduler's main thread.
In the helper we say 'Must be called from the thread this class was created on.'

https://codereview.chromium.org/1089833002/diff/1/content/child/scheduler/chi...
content/child/scheduler/child_scheduler.h:49: // called on the main thread.
Same thing here.

[Sami, 2015-04-16 12:05:21]

Nice, thanks Ross. lgtm modulo Alex's comments.

[rmcilroy, 2015-04-16 12:10:49]

https://codereview.chromium.org/1089833002/diff/1/content/child/scheduler/chi...
File content/child/scheduler/child_scheduler.h (right):

https://codereview.chromium.org/1089833002/diff/1/content/child/scheduler/chi...
content/child/scheduler/child_scheduler.h:30: // Returns true if there is high
priority work pending on the main thread
On 2015/04/16 11:32:06, alexclarke1 wrote:
> I wonder if we can avoid saying 'main thread'.  Perhaps 'thread this class was
> created on'?

Works for me (made it 'thread this scheduler was created on' instead).

https://codereview.chromium.org/1089833002/diff/1/content/child/scheduler/chi...
content/child/scheduler/child_scheduler.h:44: // Must be called from the
scheduler's main thread.
On 2015/04/16 11:32:06, alexclarke1 wrote:
> In the helper we say 'Must be called from the thread this class was created
on.'

Done.

https://codereview.chromium.org/1089833002/diff/1/content/child/scheduler/chi...
content/child/scheduler/child_scheduler.h:49: // called on the main thread.
On 2015/04/16 11:32:06, alexclarke1 wrote:
> Same thing here.

Done.

[rmcilroy, 2015-04-16 12:10:54]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-04-16 12:10:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/1089833002/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2015-04-16 12:11:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1089833002/20001

[commit-bot: I haz the power, 2015-04-16 13:23:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-16 13:25:44]

Patchset 2 (id:??) landed as
https://crrev.com/d6fe37652cf1a317e050beb8ffec5209a4143473
Cr-Commit-Position: refs/heads/master@{#325433}