Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1089773002: V8 Buildbot: Port recent asan config changes. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

V8 Buildbot: Port recent asan config changes. Fully port https://codereview.chromium.org/952653003 A change to the extra cflags was missing. The recipe is not yet used, but will be soon. BUG=444896, 315202 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_branches_Chromium_ASAN__symbolized_.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
PTAL
5 years, 8 months ago (2015-04-16 09:00:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089773002/1
5 years, 8 months ago (2015-04-16 09:06:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=294838
5 years, 8 months ago (2015-04-16 09:09:18 UTC) #6
earthdok
5 years, 8 months ago (2015-04-16 16:53:18 UTC) #7
Message was sent while issue was closed. 
On 2015/04/16 09:00:27, Michael Achenbach wrote:
> PTAL

LGTM

Maybe while you're making the switch to recipes you could also rename the bot.
"Symbolized" really doesn't mean anything in this context. Something like "no
inlining" maybe?

Powered by Google App Engine
This is Rietveld 408576698