Issue 1089543004: Ensure geolocation permission is only automatically given to search engines that are accessed over …

Issue 1089543004: Ensure geolocation permission is only automatically given to search engines that are accessed over … (Closed)

Created:
5 years, 8 months ago by Finnur

Modified:
5 years, 8 months ago

Reviewers:
vabr (Chromium), newt (away)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Ensure geolocation permission is only automatically given to search engines that are accessed over https. BUG=474476, 467798 Committed: https://crrev.com/c1379a6aa216b1b63620e6a1a9cf4fb90c430d96 Cr-Commit-Position: refs/heads/master@{#325407}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -17 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 8 (2 generated)

vabr (Chromium)

Thanks, Finnur! This LGTM from privacy perspective (not pretending I have any OWNERS powers here ...

5 years, 8 months ago (2015-04-15 13:26:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089543004/1

5 years, 8 months ago (2015-04-16 09:13:53 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 09:20:10 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c1379a6aa216b1b63620e6a1a9cf4fb90c430d96
Cr-Commit-Position: refs/heads/master@{#325407}