Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java

Issue 1089543004: Ensure geolocation permission is only automatically given to search engines that are accessed over … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
index c770fc99ed552b42f29725761584dab38618aaf6..16fc151cf1e69c30deb7665f368a0f6f9cc0ca7a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
@@ -249,9 +249,7 @@ public class SearchEngineAdapter extends BaseAdapter implements LoadListener, On
mCallback.currentSearchEngineDetermined(getSearchEngineNameAndDomain(
mContext.getResources(), templateUrl));
- PrefServiceBridge.maybeCreatePermissionForDefaultSearchEngine(true, // Allowed permission.
- false, // Not migrating.
- mContext);
+ PrefServiceBridge.maybeCreatePermissionForDefaultSearchEngine(true, mContext);
notifyDataSetChanged();
}
@@ -260,9 +258,7 @@ public class SearchEngineAdapter extends BaseAdapter implements LoadListener, On
// default search engine. If the user notices that Location is blocked for the current
// search engine and clicks the link to enable then the Location record must exist
// (otherwise it is seemingly impossible to enable after resetting a site).
- PrefServiceBridge.maybeCreatePermissionForDefaultSearchEngine(false, // Not allowed.
- false, // Not migrating.
- mContext);
+ PrefServiceBridge.maybeCreatePermissionForDefaultSearchEngine(false, mContext);
if (!LocationSettings.getInstance().isSystemLocationSettingEnabled()) {
mContext.startActivity(

Powered by Google App Engine
This is Rietveld 408576698