Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 10895024: Use new gesture event fields in more places (Closed)

Created:
8 years, 3 months ago by Rick Byers
Modified:
8 years, 3 months ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Use new gesture event fields in more places This is in preparation for WebKit switching to using the new fields (and eventually removing the overloaded deltaX/deltaY fields). BUG=143237 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154815

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 5

Patch Set 5 : rjkroege cr #

Patch Set 6 : merge with trunk #

Patch Set 7 : Fix CL diff to be against ToT (not one of my other branches) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -42 lines) Patch
M content/browser/renderer_host/gesture_event_filter.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 5 6 4 chunks +19 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 4 5 6 11 chunks +45 lines, -27 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aurax11.cc View 1 2 5 6 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Rick Byers
Hey Rob, Please review this next step in the gesture event cleanup. I've verified that ...
8 years, 3 months ago (2012-08-30 20:47:14 UTC) #1
rjkroege
http://codereview.chromium.org/10895024/diff/10003/content/browser/renderer_host/render_widget_host_unittest.cc File content/browser/renderer_host/render_widget_host_unittest.cc (right): http://codereview.chromium.org/10895024/diff/10003/content/browser/renderer_host/render_widget_host_unittest.cc#newcode366 content/browser/renderer_host/render_widget_host_unittest.cc:366: void SimulateGestureScrollUpdateEvent(float dX, float dY, int modifiers) { it ...
8 years, 3 months ago (2012-08-31 00:39:35 UTC) #2
Rick Byers
Thanks Rob! http://codereview.chromium.org/10895024/diff/10003/content/browser/renderer_host/render_widget_host_unittest.cc File content/browser/renderer_host/render_widget_host_unittest.cc (right): http://codereview.chromium.org/10895024/diff/10003/content/browser/renderer_host/render_widget_host_unittest.cc#newcode366 content/browser/renderer_host/render_widget_host_unittest.cc:366: void SimulateGestureScrollUpdateEvent(float dX, float dY, int modifiers) ...
8 years, 3 months ago (2012-08-31 14:49:29 UTC) #3
rjkroege
lgtm
8 years, 3 months ago (2012-09-04 16:53:19 UTC) #4
Rick Byers
On 2012/09/04 16:53:19, rjkroege wrote: > lgtm Thanks! sky@, ping for OWNERS
8 years, 3 months ago (2012-09-04 18:12:22 UTC) #5
sky
LGTM
8 years, 3 months ago (2012-09-04 18:24:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/10895024/15004
8 years, 3 months ago (2012-09-04 18:53:26 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-04 21:30:02 UTC) #8
Change committed as 154815

Powered by Google App Engine
This is Rietveld 408576698