Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 10895011: InternalProperty in mirror-debugger.js and ARM experimental assert (Closed)

Created:
5 years, 2 months ago by Peter Rybin
Modified:
5 years, 2 months ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

InternalProperty in mirror-debugger.js and ARM experimental assert This change is a partially commented implementation of InternalProperty support that happens to crash in Release ARM configuration. A runtime-time assert in lithium-codegen-arm.cc presumably marks the problem that leads to the crash. I run d8 with following command-line: --stress-opt --expose-debug-as debug test/mjsunit/mjsunit.js test/mjsunit/mirror-object.js --test --stress-runs=5 It happens on the 5th iteration of the stress test.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -38 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/mirror-debugger.js View 16 chunks +126 lines, -29 lines 0 comments Download
M test/mjsunit/mirror-object.js View 5 chunks +47 lines, -9 lines 0 comments Download
Trybot results:

Powered by Google App Engine
This is Rietveld efc10ee0f