Issue 1089273002: Revert of [Android] Remove android_commands uses from build/android/.

Issue 1089273002: Revert of [Android] Remove android_commands uses from build/android/. (Closed)

Created:
5 years, 8 months ago by jbudorick

Modified:
5 years, 8 months ago

Reviewers:
klundberg, perezju

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of [Android] Remove android_commands uses from build/android/. (patchset #4 id:60001 of https://codereview.chromium.org/1088793002/) Reason for revert: Broken for AdbWrapper.Devices(filters=None) Original issue's description: > [Android] Remove android_commands uses from build/android/. > > This also adds filtering to AdbWrapper.GetDevices(). > > BUG=267773 > > Committed: https://crrev.com/55d1762e76ebe2494c882594c620993419d97b98 > Cr-Commit-Position: refs/heads/master@{#325254} TBR=perezju@chromium.org,klundberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/61b860c0b5bf89c0647ea488cf787c79924bd703 Cr-Commit-Position: refs/heads/master@{#325276}

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -158 lines)			Patch
M	build/android/adb_install_apk.py	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	build/android/adb_reverse_forwarder.py	View	2 chunks	+5 lines, -9 lines	0 comments	Download
M	build/android/enable_asserts.py	View	1 chunk	+19 lines, -23 lines	0 comments	Download
M	build/android/host_heartbeat.py	View	2 chunks	+5 lines, -7 lines	0 comments	Download
M	build/android/provision_devices.py	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	build/android/pylib/device/adb_wrapper.py	View	3 chunks	+5 lines, -26 lines	0 comments	Download
M	build/android/pylib/device/adb_wrapper_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download
D	build/android/pylib/device/device_filter.py	View	1 chunk	+0 lines, -53 lines	0 comments	Download
M	build/android/pylib/device/device_utils.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	build/android/pylib/device/device_utils_test.py	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	build/android/pylib/local/device/local_device_environment.py	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	build/android/screenshot.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	build/android/tombstones.py	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	build/android/update_verification.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

jbudorick

Created Revert of [Android] Remove android_commands uses from build/android/.

5 years, 8 months ago (2015-04-15 18:22:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089273002/1

5 years, 8 months ago (2015-04-15 18:23:35 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-15 18:26:02 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/61b860c0b5bf89c0647ea488cf787c79924bd703
Cr-Commit-Position: refs/heads/master@{#325276}