Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: build/android/enable_asserts.py

Issue 1089273002: Revert of [Android] Remove android_commands uses from build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/adb_reverse_forwarder.py ('k') | build/android/host_heartbeat.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Enables dalvik vm asserts in the android device.""" 7 """Enables dalvik vm asserts in the android device."""
8 8
9 import argparse 9 from pylib import android_commands
10 from pylib.device import device_utils
11 import optparse
10 import sys 12 import sys
11 13
12 from pylib.device import device_utils
13 14
14 15 def main(argv):
15 def main(): 16 option_parser = optparse.OptionParser()
16 parser = argparse.ArgumentParser() 17 option_parser.add_option('--enable_asserts', dest='set_asserts',
17 18 action='store_true', default=None,
18 set_asserts_group = parser.add_mutually_exclusive_group(required=True)
19 set_asserts_group.add_argument(
20 '--enable_asserts', dest='set_asserts', action='store_true',
21 help='Sets the dalvik.vm.enableassertions property to "all"') 19 help='Sets the dalvik.vm.enableassertions property to "all"')
22 set_asserts_group.add_argument( 20 option_parser.add_option('--disable_asserts', dest='set_asserts',
23 '--disable_asserts', dest='set_asserts', action='store_false', 21 action='store_false', default=None,
24 help='Removes the dalvik.vm.enableassertions property') 22 help='Removes the dalvik.vm.enableassertions property')
25 23 options, _ = option_parser.parse_args(argv)
26 args = parser.parse_args()
27 24
28 # TODO(jbudorick): Accept optional serial number and run only for the 25 # TODO(jbudorick): Accept optional serial number and run only for the
29 # specified device when present. 26 # specified device when present.
30 devices = device_utils.DeviceUtils.parallel() 27 devices = android_commands.GetAttachedDevices()
31 28 for device in [device_utils.DeviceUtils(serial) for serial in devices]:
32 def set_java_asserts_and_restart(device): 29 if options.set_asserts != None:
33 if device.SetJavaAsserts(args.set_asserts): 30 if device.SetJavaAsserts(options.set_asserts):
34 device.RunShellCommand('stop') 31 # TODO(jbudorick) How to best do shell restarts after the
35 device.RunShellCommand('start') 32 # android_commands refactor?
36 33 device.RunShellCommand('stop')
37 devices.pMap(set_java_asserts_and_restart) 34 device.RunShellCommand('start')
38 return 0
39 35
40 36
41 if __name__ == '__main__': 37 if __name__ == '__main__':
42 sys.exit(main()) 38 main(sys.argv)
OLDNEW
« no previous file with comments | « build/android/adb_reverse_forwarder.py ('k') | build/android/host_heartbeat.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698