Make the Android GN debug component build actually build.

base/BUILD.gn

Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index b9f134e3af0b07bb80ae759229cb42375845e6a2..65090ba158c6f5dd7c5b000981b583382fbaaec8 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -497,6 +497,8 @@ component("base") {
     "third_party/dmg_fp/g_fmt.cc",
     "third_party/icu/icu_utf.cc",
     "third_party/icu/icu_utf.h",
+    "third_party/nspr/prtime.cc",
+    "third_party/nspr/prtime.h",
     "third_party/superfasthash/superfasthash.c",
     "thread_task_runner_handle.cc",
     "thread_task_runner_handle.h",
@@ -640,7 +642,6 @@ component("base") {
     ":base_static",
     "//base/allocator:allocator_extension_thunks",
     "//base/third_party/dynamic_annotations",
-    "//base/third_party/nspr",
     "//third_party/modp_b64",
   ]
 
@@ -1307,7 +1308,6 @@ test("base_unittests") {
     "//base/test:run_all_unittests",
     "//base/test:test_support",
     "//base/third_party/dynamic_annotations",
-    "//base/third_party/nspr",

[cjhopman, 2015/04/16 19:02:18]

I think that this line is actually the problem with nspr. nothing but
//base:base should be depending on nspr (and everything else should get the
stuff there through a dependency on //base:base)

[Dirk Pranke, 2015/04/16 20:31:52]

//base:base can't depend on nspr, because nspr depends on //base:base :).

So, I think we just need to fold nspr into base like we have on GYP.

[cjhopman, 2015/04/16 20:50:33]

That's not true. Before your change nspr didn't have a dep on base (even though
it refers to things in base).

//base:base did have a dep on nspr and nspr is part of the base component (i.e.
that shared library exposes the appropriate nspr symbols).

my understanding is that current approach (w/ split out nspr) has the problem
that there is no way to pass a header check (because nspr uses headers from base
but doesn't depend on it and can't depend on it because then there'd be a
cycle). I guess the thing to do at that point would be to split the base target
into more smaller targets.

[Dirk Pranke, 2015/04/16 20:59:32]

Well, yeah, it didn't have an explicit dependency on base, but it should've (due
to the header include you mentioned).

Do you not want to just fold nspr back into base? I'm not seeing the downside to
that, and Brett didn't have any objections. Creating a separate component for
one file that causes cyclical header dependencies just seems like a lot of pain
for no gain. It seems like splitting out os_compat_android (and whatever else we
might need) into a third target just to solve this is adding more complexity to
solve an already unnecessarily complex thing.

[cjhopman, 2015/04/16 21:03:47]

Folding it in is definitely fine with me.

It seemed that you were unsure why it was failing to link and I was letting you
know why in case you wanted to do something different once you had that info.

     "//base/trace_event:trace_event_unittests",
     "//testing/gmock",
     "//testing/gtest",