Make the Android GN debug component build actually build.

base/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
@@ skipping 479 matching lines @@
     "task/cancelable_task_tracker.h",
     "task_runner.cc",
     "task_runner.h",
     "task_runner_util.h",
     "template_util.h",
     "third_party/dmg_fp/dmg_fp.h",
     "third_party/dmg_fp/dtoa_wrapper.cc",
     "third_party/dmg_fp/g_fmt.cc",
     "third_party/icu/icu_utf.cc",
     "third_party/icu/icu_utf.h",
+    "third_party/nspr/prtime.cc",
+    "third_party/nspr/prtime.h",
     "third_party/superfasthash/superfasthash.c",
     "thread_task_runner_handle.cc",
     "thread_task_runner_handle.h",
     "threading/non_thread_safe.h",
     "threading/non_thread_safe_impl.cc",
     "threading/non_thread_safe_impl.h",
     "threading/platform_thread.h",
     "threading/platform_thread_android.cc",
     "threading/platform_thread_internal_posix.cc",
     "threading/platform_thread_internal_posix.h",
@@ skipping 123 matching lines @@
     "sys_info_freebsd.cc",
     "sys_info_openbsd.cc",
   ]
 
   configs += [ ":base_implementation" ]
 
   deps = [
     ":base_static",
     "//base/allocator:allocator_extension_thunks",
     "//base/third_party/dynamic_annotations",
-    "//base/third_party/nspr",
     "//third_party/modp_b64",
   ]
 
   public_deps = [
     ":base_paths",
     "//base/debug",
     "//base/json",
     "//base/memory",
     "//base/metrics",
     "//base/process",
@@ skipping 646 matching lines @@
   deps = [
     ":base",
     ":i18n",
     ":message_loop_tests",
     ":prefs",
     ":prefs_test_support",
     "//base/allocator",
     "//base/test:run_all_unittests",
     "//base/test:test_support",
     "//base/third_party/dynamic_annotations",
-    "//base/third_party/nspr",

[cjhopman, 2015/04/16 19:02:18]

I think that this line is actually the problem with nspr. nothing but
//base:base should be depending on nspr (and everything else should get the
stuff there through a dependency on //base:base)

[Dirk Pranke, 2015/04/16 20:31:52]

//base:base can't depend on nspr, because nspr depends on //base:base :).

So, I think we just need to fold nspr into base like we have on GYP.

[cjhopman, 2015/04/16 20:50:33]

That's not true. Before your change nspr didn't have a dep on base (even though
it refers to things in base).

//base:base did have a dep on nspr and nspr is part of the base component (i.e.
that shared library exposes the appropriate nspr symbols).

my understanding is that current approach (w/ split out nspr) has the problem
that there is no way to pass a header check (because nspr uses headers from base
but doesn't depend on it and can't depend on it because then there'd be a
cycle). I guess the thing to do at that point would be to split the base target
into more smaller targets.

[Dirk Pranke, 2015/04/16 20:59:32]

Well, yeah, it didn't have an explicit dependency on base, but it should've (due
to the header include you mentioned).

Do you not want to just fold nspr back into base? I'm not seeing the downside to
that, and Brett didn't have any objections. Creating a separate component for
one file that causes cyclical header dependencies just seems like a lot of pain
for no gain. It seems like splitting out os_compat_android (and whatever else we
might need) into a third target just to solve this is adding more complexity to
solve an already unnecessarily complex thing.

[cjhopman, 2015/04/16 21:03:47]

Folding it in is definitely fine with me.

It seemed that you were unsure why it was failing to link and I was letting you
know why in case you wanted to do something different once you had that info.

     "//base/trace_event:trace_event_unittests",
     "//testing/gmock",
     "//testing/gtest",
     "//third_party/icu",
   ]
 
   # Allow more direct string conversions on platforms with native utf8
   # strings
   if (is_mac || is_ios || is_chromeos) {
     defines = [ "SYSTEM_NATIVE_UTF8" ]
@@ skipping 158 matching lines @@
 
   # GYP: //base.gyp:base_java_unittest_support
   android_library("base_java_unittest_support") {
     deps = [
       ":base_java",
     ]
     java_files =
         [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
   }
 }