Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1089073002: Change tessellator sweep direction to depend on path aspect ratio. (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change tessellator sweep direction to depend on path aspect ratio. The tessellating path renderer uses several sweep-line algorithms, whose sweep direction can be either in X or Y. It is currently set to in-X at compile time, but a better approach is to make it runtime-configurable, and use the path aspect ratio as a heuristic to determine the optimal sweep direction. BUG=skia:3725 Committed: https://skia.googlesource.com/skia/+/6bd5137e11071116fe279e2f26264f01baeff1aa

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Change to a Comparator struct; fix formatting. #

Patch Set 4 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -130 lines) Patch
M src/gpu/GrTessellatingPathRenderer.cpp View 1 2 3 23 chunks +143 lines, -130 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089073002/60001
5 years, 8 months ago (2015-04-14 21:52:07 UTC) #3
Stephen White
Greg: PTAL. Thanks!
5 years, 8 months ago (2015-04-14 21:52:08 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-14 21:58:05 UTC) #6
Stephen White
Brian || Greg: PTAL. Thanks! :)
5 years, 8 months ago (2015-04-14 22:02:12 UTC) #8
bsalomon
lgtm
5 years, 8 months ago (2015-04-15 13:32:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1089073002/60001
5 years, 8 months ago (2015-04-15 13:49:07 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 14:32:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6bd5137e11071116fe279e2f26264f01baeff1aa

Powered by Google App Engine
This is Rietveld 408576698