runtime/vm/intermediate_language_ia32.cc - Issue 1089003002: Implement bigint shift intrinsics on IA32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 1089003002: Implement bigint shift intrinsics on IA32. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 45179)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -6171,7 +6171,7 @@

__ cmpl(ECX, Immediate(31));

__ j(ABOVE, &large_shift);

- __ shrdl(left_lo, left_hi); // Shift count in CL.

+ __ shrdl(left_lo, left_hi, ECX); // Shift count in CL.

__ sarl(left_hi, ECX); // Shift count in CL.

__ jmp(&done, Assembler::kNearJump);

@@ -6190,7 +6190,7 @@

__ cmpl(ECX, Immediate(31));

__ j(ABOVE, &large_shift);

- __ shldl(left_hi, left_lo); // Shift count in CL.

+ __ shldl(left_hi, left_lo, ECX); // Shift count in CL.

__ shll(left_lo, ECX); // Shift count in CL.

// Check for overflow by shifting back the high 32 bits

// and comparing with the input.

@@ -6221,7 +6221,7 @@

__ cmpl(ECX, Immediate(31));

__ j(ABOVE, &large_shift);

- __ shldl(left_hi, left_lo); // Shift count in CL.

+ __ shldl(left_hi, left_lo, ECX); // Shift count in CL.

__ shll(left_lo, ECX); // Shift count in CL.

__ jmp(&done, Assembler::kNearJump);

« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/intrinsifier_arm.cc » ('j') | no next file with comments »