runtime/vm/assembler_x64_test.cc - Issue 1089003002: Implement bigint shift intrinsics on IA32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_x64_test.cc

Issue 1089003002: Implement bigint shift intrinsics on IA32. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_x64_test.cc

===================================================================

--- runtime/vm/assembler_x64_test.cc (revision 45179)

+++ runtime/vm/assembler_x64_test.cc (working copy)

@@ -1360,10 +1360,10 @@

const int32_t right = 0xffffffff;

const int32_t shifted = 0xf0000003;

__ movl(RDX, Immediate(left));

- __ movl(RAX, Immediate(right));

+ __ movl(R8, Immediate(right));

__ movl(RCX, Immediate(2));

__ shll(RDX, RCX); // RDX = 0xff000000 << 2 == 0xfc000000

- __ shldl(RDX, RAX, Immediate(2));

+ __ shldl(RDX, R8, Immediate(2));

// RDX = high32(0xfc000000:0xffffffff << 2) == 0xf0000003

__ cmpl(RDX, Immediate(shifted));

__ j(EQUAL, &donetest15a);

@@ -1377,10 +1377,10 @@

const int64_t right = 0xffffffffffffffff;

const int64_t shifted = 0xf000000000000003;

__ movq(RDX, Immediate(left));

- __ movq(RAX, Immediate(right));

+ __ movq(R8, Immediate(right));

__ movq(RCX, Immediate(2));

__ shlq(RDX, RCX); // RDX = 0xff00000000000000 << 2 == 0xfc00000000000000

- __ shldq(RDX, RAX, Immediate(2));

+ __ shldq(RDX, R8, Immediate(2));

// RDX = high64(0xfc00000000000000:0xffffffffffffffff << 2)

// == 0xf000000000000003

__ cmpq(RDX, Immediate(shifted));

@@ -1395,10 +1395,10 @@

const int64_t right = 0xffffffffffffffff;

const int64_t shifted = 0xf000000000000003;

__ movq(RDX, Immediate(left));

- __ movq(RAX, Immediate(right));

+ __ movq(R8, Immediate(right));

__ movq(RCX, Immediate(2));

__ shlq(RDX, RCX); // RDX = 0xff00000000000000 << 2 == 0xfc00000000000000

- __ shldq(RDX, RAX, RCX);

+ __ shldq(RDX, R8, RCX);

// RDX = high64(0xfc00000000000000:0xffffffffffffffff << 2)

// == 0xf000000000000003

__ cmpq(RDX, Immediate(shifted));

@@ -1413,10 +1413,10 @@

const int64_t right = 0xffffffffffffffff;

const int64_t shifted = 0xcff0000000000000;

__ movq(RDX, Immediate(left));

- __ movq(RAX, Immediate(right));

+ __ movq(R8, Immediate(right));

__ movq(RCX, Immediate(2));

__ shrq(RDX, RCX); // RDX = 0xff00000000000000 >> 2 == 0x3fc0000000000000

- __ shrdq(RDX, RAX, RCX);

+ __ shrdq(RDX, R8, RCX);

// RDX = low64(0xffffffffffffffff:0x3fc0000000000000 >> 2)

// == 0xcff0000000000000

__ cmpq(RDX, Immediate(shifted));

« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »