Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1088903008: Update {virtual,override} to follow C++11 style in net. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org, gavinp+disk_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in net. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d Cr-Commit-Position: refs/heads/master@{#326489}

Patch Set 1 #

Patch Set 2 : Add an override. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -66 lines) Patch
M net/base/elements_upload_data_stream_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/base/network_change_notifier_win_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/cookies/cookie_monster.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/backend_impl_v3.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/sparse_control_v3.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/dns_test_util.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M net/dns/mock_mdns_socket_factory.h View 1 4 chunks +8 lines, -7 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +21 lines, -25 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/test/net_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_http_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_channel_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
rsleevi: Please review
5 years, 8 months ago (2015-04-23 03:20:56 UTC) #2
Ryan Sleevi
lgtm
5 years, 8 months ago (2015-04-23 10:15:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088903008/20001
5 years, 8 months ago (2015-04-23 10:15:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 10:18:46 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 10:19:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3f30d02fb6e676e9a46776325e21f64903c201d
Cr-Commit-Position: refs/heads/master@{#326489}

Powered by Google App Engine
This is Rietveld 408576698