net/socket/client_socket_pool_base.h - Issue 1088903008: Update {virtual,override} to follow C++11 style in net.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_base.h

Issue 1088903008: Update {virtual,override} to follow C++11 style in net. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add an override. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/client_socket_pool_base.h

diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h

index 2e3c05e9880bbef4846ad5b7587f1988c73387a4..6997e1d370cd441fc8309045328ba16aeacf8d74 100644

--- a/net/socket/client_socket_pool_base.h

+++ b/net/socket/client_socket_pool_base.h

@@ -846,9 +846,9 @@ class ClientSocketPoolBase {

explicit ConnectJobFactoryAdaptor(ConnectJobFactory* connect_job_factory)

: connect_job_factory_(connect_job_factory) {}

- virtual ~ConnectJobFactoryAdaptor() {}

+ ~ConnectJobFactoryAdaptor() override {}

- virtual scoped_ptr<ConnectJob> NewConnectJob(

+ scoped_ptr<ConnectJob> NewConnectJob(

const std::string& group_name,

const internal::ClientSocketPoolBaseHelper::Request& request,

ConnectJob::Delegate* delegate) const override {

« no previous file with comments | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/test/net_test_suite.cc » ('j') | no next file with comments »