Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1088843002: Add #include <algorithm> to code that is missing it. (Closed)

Created:
5 years, 8 months ago by Daniel Bratell
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
blink-reviews, shans, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, blink-reviews-wtf_chromium.org, Steve Block, rwlbuis, pdr+graphicswatchlist_chromium.org, dstockwell, blink-reviews-css, Timothy Loh, Justin Novosad, danakj, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, aandrey+blink_chromium.org, Eric Willigers, rjwright, blink-reviews-style_chromium.org, zoltan1, sof, jbroman, Dominik Röttsches, krit, darktears, Nate Chapin, tyoshino+watch_chromium.org, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Stephen Chennney, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add #include <algorithm> to code that is missing it. Including <algorithm> is compile time expensive but not including it when it's used causes compiler errors when other code removes their includes of <algorithm>. To prevent possible future compilation errors with C++11 stl, I've also added #include <utility> to headers that use std::swap since <algorithm> isn't certain to provide std::swap. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194281

Patch Set 1 #

Patch Set 2 : #

Total comments: 13

Patch Set 3 : With less comments and more utility #

Patch Set 4 : And no more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M Source/core/css/CSSSelector.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/DOMStringList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fetch/CrossOriginAccessControl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/ColumnInfo.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/style/GridCoordinate.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/Timer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/animation/CubicBezierControlPoints.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/animation/TimingFunction.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/Character.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/geometry/DoublePoint.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/geometry/FloatBox.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/geometry/LayoutPoint.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/geometry/LayoutRectOutsets.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/ColorSpace.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/Gradient.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/weborigin/KnownPorts.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/Alignment.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/ArrayBufferView.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/wtf/MathExtras.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/OwnPtr.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/RawPtr.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/wtf/RefPtr.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/wtf/RetainPtr.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/Vector.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/wtf/text/WTFString.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Daniel Bratell
thakis, this ended up being the opposite of what I talked about. Instead of removing ...
5 years, 8 months ago (2015-04-14 15:49:37 UTC) #2
Daniel Bratell
Ping thakis, just cleanup, but if you have 5 minutes.
5 years, 8 months ago (2015-04-16 15:01:59 UTC) #3
Nico
i stopped saying the same thing in wtf refptr, please self-review the rest based on ...
5 years, 8 months ago (2015-04-16 21:16:56 UTC) #4
Daniel Bratell
Done! I was a bit unclear whether <algorithm> will include <utility> or not in C++11. ...
5 years, 8 months ago (2015-04-21 09:33:17 UTC) #5
Nico
lgtm :-/
5 years, 8 months ago (2015-04-22 16:55:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088843002/60001
5 years, 8 months ago (2015-04-23 09:49:06 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 11:15:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194281

Powered by Google App Engine
This is Rietveld 408576698