Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: build/android/tombstones.py

Issue 1088793002: [Android] Remove android_commands uses from build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: docstrings for device_filter.py Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/screenshot.py ('k') | build/android/update_verification.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/tombstones.py
diff --git a/build/android/tombstones.py b/build/android/tombstones.py
index 1a958ac28673c9d9a7ac83adc8c64fa6f75b9f5f..3f3508631ada13a58cac2f83826cccef10fa6752 100755
--- a/build/android/tombstones.py
+++ b/build/android/tombstones.py
@@ -19,8 +19,9 @@ import subprocess
import sys
import optparse
-from pylib import android_commands
+from pylib.device import adb_wrapper
from pylib.device import device_errors
+from pylib.device import device_filter
from pylib.device import device_utils
from pylib.utils import run_tests_helper
@@ -235,14 +236,15 @@ def main():
if options.device:
devices = [options.device]
else:
- devices = android_commands.GetAttachedDevices()
+ devices = adb_wrapper.AdbWrapper.Devices(
+ filters=device_filter.DefaultFilters())
# This must be done serially because strptime can hit a race condition if
# used for the first time in a multithreaded environment.
# http://bugs.python.org/issue7980
tombstones = []
- for device_serial in devices:
- device = device_utils.DeviceUtils(device_serial)
+ for adb in devices:
+ device = device_utils.DeviceUtils(adb)
tombstones += _GetTombstonesForDevice(device, options)
_ResolveTombstones(options.jobs, tombstones)
« no previous file with comments | « build/android/screenshot.py ('k') | build/android/update_verification.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698