build/android/screenshot.py - Issue 1088793002: [Android] Remove android_commands uses from build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/screenshot.py

Issue 1088793002: [Android] Remove android_commands uses from build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: docstrings for device_filter.py Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/screenshot.py

diff --git a/build/android/screenshot.py b/build/android/screenshot.py

index 8fe2a95ddd9948e783f7c0831abf4deb421fea91..4c1e247fcef09423c4b183458e005807b07482de 100755

--- a/build/android/screenshot.py

+++ b/build/android/screenshot.py

@@ -11,8 +11,9 @@ import optparse

import os

import sys

-from pylib import android_commands

from pylib import screenshot

+from pylib.device import adb_wrapper

+from pylib.device import device_filter

from pylib.device import device_utils

def _PrintMessage(heading, eol='\n'):

@@ -69,7 +70,8 @@ def main():

if options.verbose:

logging.getLogger().setLevel(logging.DEBUG)

- devices = android_commands.GetAttachedDevices()

+ devices = adb_wrapper.AdbWrapper.Devices(

+ filters=device_filter.DefaultFilters())

if not options.device and len(devices) > 1:

parser.error('Multiple devices are attached. '

« no previous file with comments | « build/android/pylib/local/device/local_device_environment.py ('k') | build/android/tombstones.py » ('j') | no next file with comments »