Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2599)

Unified Diff: build/android/enable_asserts.py

Issue 1088793002: [Android] Remove android_commands uses from build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/enable_asserts.py
diff --git a/build/android/enable_asserts.py b/build/android/enable_asserts.py
index 0e30bc2a1736d529511b038007f6e9bc707c2b7e..ed0d2db9be4345af150806016def7fb4639128ef 100755
--- a/build/android/enable_asserts.py
+++ b/build/android/enable_asserts.py
@@ -6,11 +6,11 @@
"""Enables dalvik vm asserts in the android device."""
-from pylib import android_commands
-from pylib.device import device_utils
import optparse
import sys
+from pylib.device import device_utils
+
def main(argv):
option_parser = optparse.OptionParser()
@@ -24,14 +24,18 @@ def main(argv):
# TODO(jbudorick): Accept optional serial number and run only for the
# specified device when present.
- devices = android_commands.GetAttachedDevices()
- for device in [device_utils.DeviceUtils(serial) for serial in devices]:
- if options.set_asserts != None:
- if device.SetJavaAsserts(options.set_asserts):
- # TODO(jbudorick) How to best do shell restarts after the
- # android_commands refactor?
- device.RunShellCommand('stop')
- device.RunShellCommand('start')
+ devices = device_utils.DeviceUtils.parallel()
+
+ if options.set_asserts == None:
perezju 2015/04/14 12:39:10 maybe make the options required and mutually exclu
jbudorick 2015/04/14 15:29:57 I'm going to regret making a behavioral change in
+ return 0
+
+ def set_java_asserts_and_restart(device):
+ if device.SetJavaAsserts(options.set_asserts):
+ device.RunShellCommand('stop')
+ device.RunShellCommand('start')
+
+ devices.pMap(set_java_asserts_and_restart)
+ return 0
if __name__ == '__main__':

Powered by Google App Engine
This is Rietveld 408576698