Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: build/android/enable_asserts.py

Issue 1088793002: [Android] Remove android_commands uses from build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Enables dalvik vm asserts in the android device.""" 7 """Enables dalvik vm asserts in the android device."""
8 8
9 from pylib import android_commands
10 from pylib.device import device_utils
11 import optparse 9 import optparse
12 import sys 10 import sys
13 11
12 from pylib.device import device_utils
13
14 14
15 def main(argv): 15 def main(argv):
16 option_parser = optparse.OptionParser() 16 option_parser = optparse.OptionParser()
17 option_parser.add_option('--enable_asserts', dest='set_asserts', 17 option_parser.add_option('--enable_asserts', dest='set_asserts',
18 action='store_true', default=None, 18 action='store_true', default=None,
19 help='Sets the dalvik.vm.enableassertions property to "all"') 19 help='Sets the dalvik.vm.enableassertions property to "all"')
20 option_parser.add_option('--disable_asserts', dest='set_asserts', 20 option_parser.add_option('--disable_asserts', dest='set_asserts',
21 action='store_false', default=None, 21 action='store_false', default=None,
22 help='Removes the dalvik.vm.enableassertions property') 22 help='Removes the dalvik.vm.enableassertions property')
23 options, _ = option_parser.parse_args(argv) 23 options, _ = option_parser.parse_args(argv)
24 24
25 # TODO(jbudorick): Accept optional serial number and run only for the 25 # TODO(jbudorick): Accept optional serial number and run only for the
26 # specified device when present. 26 # specified device when present.
27 devices = android_commands.GetAttachedDevices() 27 devices = device_utils.DeviceUtils.parallel()
28 for device in [device_utils.DeviceUtils(serial) for serial in devices]: 28
29 if options.set_asserts != None: 29 if options.set_asserts == None:
perezju 2015/04/14 12:39:10 maybe make the options required and mutually exclu
jbudorick 2015/04/14 15:29:57 I'm going to regret making a behavioral change in
30 if device.SetJavaAsserts(options.set_asserts): 30 return 0
31 # TODO(jbudorick) How to best do shell restarts after the 31
32 # android_commands refactor? 32 def set_java_asserts_and_restart(device):
33 device.RunShellCommand('stop') 33 if device.SetJavaAsserts(options.set_asserts):
34 device.RunShellCommand('start') 34 device.RunShellCommand('stop')
35 device.RunShellCommand('start')
36
37 devices.pMap(set_java_asserts_and_restart)
38 return 0
35 39
36 40
37 if __name__ == '__main__': 41 if __name__ == '__main__':
38 main(sys.argv) 42 main(sys.argv)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698